Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate provider sources #115

Open
SylvainCorlay opened this issue Jun 8, 2022 · 2 comments
Open

Consolidate provider sources #115

SylvainCorlay opened this issue Jun 8, 2022 · 2 comments

Comments

@SylvainCorlay
Copy link
Contributor

Hello, ipyleaflet developer here.

I noticed that JSON listing the provider sources is generated by _parse_leaflet_providers.py which extracts the data from https://github.com/leaflet-extras/leaflet-providers with Selenium. This seems a bit overkill. Did anyone try reaching out to the developers of leaflet-providers so that this information is directly available in a standalone JSON file?

This JSON file could also directly be packaged independently of the rest of the JS logic of leaflet-providers.

cc @HaudinFlorence.
@martinfleis
Copy link
Member

Hey, I don't think so. When we created xyzservices the code scraping the data from leaflet-extras/leaflet-providers was already existing in contextily and we just moved it here. But I agree that it may be worth checking with them if it could be simplified.

@SylvainCorlay
Copy link
Contributor Author

I opened an issue about this upstream: leaflet-extras/leaflet-providers#457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SylvainCorlay @martinfleis