Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: assorted cleanups in release workflow #467

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 5, 2024

Some small follow-ups on #466:

  • In shapely, we noticed that when using multiple docker images in a single job (through a matrix parametrization), only one of the images was cached (and you could see the same here), requiring to specify a scope to get proper caching.
  • When testing, we don't actually need to checkout the source (that also avoids the cd ..)
  • It seemed that the cache was not working for the MacOS x86_64 build. Not sure if that is related to having two jobs on the same macos-12 runner (although they use a unique cache key, so wouldn't expect that), but I saw that vcpkg now has experimental support for directly using the github actions cache (https://learn.microsoft.com/en-us/vcpkg/consume/binary-caching-github-actions-cache), so trying out this option. -> this seems to work only partially .. For the arm build, it only restores cached binaries that are not arm specific (maybe because the runner is actually intel mac, nor arm?)
  • Removing some no longer necessary version restrictions in the requirements-wheel-test.txt file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant