You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this point the wheel build still doesn't include libspatialite support, i.e. the libspatialite feature is not enabled in the vcpkg GDAL build.
Looking at it again, it seems we could do that . @brendan-ward you commented about that in #86 (comment):
Not sure if this matters, but noting for the record that our vcpkg build does not include libspatialite (we don't enable that as an add-on feature); it is LGPL licensed, which likely has license implications for the wheels we create. I believe Fiona also does not build against libspatialite.
In #161 I first added libspatialite feature, but then removed it again before the PR was merged, and I don't directly see any discussion or explanation that explains why I did that .. But there is a bit of discussion later at #161 (comment), which again mentions that fiona also doesn't have this.
Now, I don't think licensing is a problem, given that GEOS also uses LGPL, and we do already include that in the wheels.
Given that vcpkg has the feature to build GDAL with libspatialite, we should probably just try that.
As mentioned here, geopandas/geopandas#3223, think through whether it it would be better to include it or not...
The text was updated successfully, but these errors were encountered: