Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifold laplacian for general manifolds #47

Open
imbirik opened this issue Jun 22, 2022 · 0 comments
Open

Manifold laplacian for general manifolds #47

imbirik opened this issue Jun 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@imbirik
Copy link
Collaborator

imbirik commented Jun 22, 2022

I've tried to run code that checks heat solution on SO, but there is a problem with laplace_operator.
Code sample:

from geomstats.geometry.special_orthogonal import _SpecialOrthogonalMatrices
so = _SpecialOrthogonalMatrices(5)
x  = so.rand()
dfdt, _, _ = torch.autograd.grad(heat_kernel(t, x[None], y[None]), (t, x, y), allow_unused=True)
egrad = lambda u: torch.autograd.grad(heat_kernel(t, u[None], y[None]), (t, u, y))[1]
fx = lambda u: heat_kernel(t, u[None], y[None])
ehess = lambda u, h: torch.autograd.functional.hvp(fx, u, h)[1] 
lapf = manifold_laplacian(x, space, egrad, ehess)

I suspect that the problem is in function tangent_onb in manifold_utils.py. Such approach should work only for $M^n $ embedded in $\mathbb{R}^{n+1}$.

@vabor112 vabor112 added the enhancement New feature or request label Oct 17, 2022
@vabor112 vabor112 changed the title Manifold laplacian does not work in general. Manifold laplacian for general manifolds Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants