Fix test setups for tpetra#6985
Open
gassmoeller wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all the developments in deal.II and the prior PRs about Tpetra support in ASPECT almost all of our test cases now run with Tpetra vectors, matrices, and solvers.
This PR adjusts the setup of a few of the remaining problematic cases.
maximum_horizontal_compressive_stress_case_two.prmI think accidentally sets a very large viscosity (5e24) for a very small model with prescribed deformation, which leads to unrealistic stress values. I suspect our pressure scaling doesnt work any more for this regime. I could get the test to pass with 5e21 viscosity, but there is another casemaximum_horizontal_compressive_stress_case_one.prmwhich uses the settings I used here (viscosity = 0.5), which is closer to what is expected in a nondimensional setup like this.time_stepping_repeat_particles_iterated_advection.prmprescribes a step jump in velocity at a fixed time, which breaks the advection solver even with the diagonal strengthening fallback. Our default solver tolerance is 1e-12, not really because we need that value, but because the advection system is typically easy and fast to solve. With the new solver I can still converge to around 1e-9, but I used 1e-8 to be safe. Alternatively, one could use a smoother velocity change, or stronger diagonal strengthening in the code (but I tried, and I couldnt get it to work with a tolerance of 1e-12 even with stronger strengthening; 1e-11 might work).I would like to get this in as its own PR to separate the changes to the tests from the other changes I will make when enabling Tpetra support.