feat: add support for HERE Geocoding & Search API v7 (GS7)#4
Closed
Giacomo92 wants to merge 5 commits intogeocoder-php:masterfrom
Closed
feat: add support for HERE Geocoding & Search API v7 (GS7)#4Giacomo92 wants to merge 5 commits intogeocoder-php:masterfrom
Giacomo92 wants to merge 5 commits intogeocoder-php:masterfrom
Conversation
- Implement GS7 geocoding and reverse geocoding endpoints. - Add createUsingApiKey static factory for easier instantiation. - Enhance HereAddress model with locationName and helper methods. - Update documentation and migrate to PHPUnit 10. BREAKING CHANGE: bump minimum PHP version to 8.2
Author
|
@jbelien can u please take a look? Thanks |
Member
|
Hello @Giacomo92, This is a read-only repository ; please submit your changes and PR in our main repository: https://github.com/geocoder-php/Geocoder/tree/master/src/Provider/Here Thanks. |
Member
|
Also, could you split this PR in 2 separate PRs: 1 for the provider changes and 1 for the PHPUnit upgrade (since it's not related to the initial changes)? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bump minimum PHP version to 8.2