Hotfix/geoips #273
Hotfix/geoips #273
Conversation
| @@ -3,3 +3,12 @@ composer.lock | |||
| composer.phar | |||
| phpunit.xml | |||
| php-cs-fixer.phar | |||
|
|
|||
| # common IDE dirs | |||
There was a problem hiding this comment.
those files should not be ignored per project, but within your global git config on your machine.
There was a problem hiding this comment.
Well, yes. It's common practice in OSS projects, github auto-generates those etc. It's just a nice thing to have and helps contributors weed out unnecessary dirs. Not required and I'm not opinionated on it though.
There was a problem hiding this comment.
I'd rather prefer not to include this change, especially in this PR.
|
great job overall! |
|
Thx Will. |
|
|
||
| if (!is_array($response) || !count($response)) { | ||
| throw new NoResultException(sprintf('Could not execute query %s', $query)); | ||
| if ( |
There was a problem hiding this comment.
so now you can wrap everything on a same line :)
|
You can squash your commits, and use PHP-CS-Fixer (just in case), and that will be perfect. |
|
Done. |
|
squash? |
|
I've already pushed. |
|
Unless you want a completely new branch, which means discussion will be lost. |
|
na, but I want a single commit, not 6.. |
|
I can't rebase something that is already pushed. What I could do is rebase on a new branch and send new PR, but this will remove the diss. here. |
|
well you can: Then: |
|
Strange, github accepted it.... ok then. |
|
Thanks! |
|
Release 2.3.2 includes this fix. |
Fix #267.
I've covered 100% of the API documentation, including all status and error codes and possible responses.