test coverage

Author: AronNovak

src/Provider/Geonames/Geonames.php

@@ -84,7 +84,7 @@ public function __construct(ClientInterface $client, string $username, ?string $
         $this->token = $token;
 
         // Determine base URL based on secure flag.
-        if ($secure === TRUE) {
+        if ($secure === true) {
             $this->baseUrl = self::PREMIUM_WEBSERVICE_BASE_URL;
         } else {
             $this->baseUrl = self::FREE_WEBSERVICE_BASE_URL;

src/Provider/Geonames/Tests/GeonamesTest.php

@@ -22,9 +22,13 @@
 
 class GeonamesTest extends BaseTestCase
 {
-    protected function getCacheDir(): string
+    protected function getCacheDir(): ?string
     {
-        return __DIR__.'/.cached_responses';
+        if (isset($_SERVER['USE_CACHED_RESPONSES']) && true === $_SERVER['USE_CACHED_RESPONSES']) {
+            return __DIR__.'/.cached_responses';
+        }
+
+        return null;
     }
 
     public function testGetName(): void
@@ -368,4 +372,29 @@ public function testReverseWithBadCoordinates(): void
         $this->assertInstanceOf(Collection::class, $result);
         $this->assertEquals(0, $result->count());
     }
+
+    public function testGeocodeWithPremiumEndpointAndToken(): void
+    {
+        if (!isset($_SERVER['GEONAMES_USERNAME']) || !isset($_SERVER['GEONAMES_TOKEN'])) {
+            $this->markTestSkipped('You need to configure the GEONAMES_USERNAME and GEONAMES_TOKEN values in phpunit.xml');
+        }
+
+        $provider = new Geonames(
+            $this->getHttpClient($_SERVER['GEONAMES_USERNAME']),
+            $_SERVER['GEONAMES_USERNAME'],
+            $_SERVER['GEONAMES_TOKEN'],
+            true
+        );
+        $results = $provider->geocodeQuery(GeocodeQuery::create('London'));
+
+        $this->assertInstanceOf(\Geocoder\Model\AddressCollection::class, $results);
+        $this->assertGreaterThan(0, $results->count());
+
+        /** @var Location $result */
+        $result = $results->first();
+        $this->assertInstanceOf(\Geocoder\Model\Address::class, $result);
+        $this->assertNotNull($result->getCoordinates());
+        $this->assertEquals('United Kingdom', $result->getCountry()->getName());
+        $this->assertEquals('GB', $result->getCountry()->getCode());
+    }
 }