Skip to content

The cookie header was not parsed correctly #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

The cookie header was not parsed correctly #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa9b800
The cookie header was not parsed correctly; it failed when the value …
claudiamurialdo Jan 17, 2024
6ea34be
Minor to force build process.
claudiamurialdo Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion dotnet/src/dotnetframework/GxClasses/Domain/GxHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,12 @@ void setHeaders(HttpRequestMessage request, CookieContainer cookies)
{
if (cookie.Contains("="))
{
cookies.Add(new Uri(request.RequestUri.Host), new Cookie(cookie.Split('=')[0], cookie.Split('=')[1]) { Domain = request.RequestUri.Host });
UriBuilder uriBuilder = new UriBuilder(request.RequestUri.Scheme, request.RequestUri.Host);
Cookie pCookie = ParseCookie(cookie, request.RequestUri.Host);
if (pCookie != null)
{
cookies.Add(uriBuilder.Uri, pCookie);
}
}
}
break;
Expand All @@ -608,6 +613,16 @@ void setHeaders(HttpRequestMessage request, CookieContainer cookies)
}
InferContentType(contentType, request);
}
Cookie ParseCookie(string cookie, string domain)
{
string[] values = cookie.TrimEnd(';').Split('=');
if (values.Length >= 2) {
string cookieName = values[0].Trim();
string cookieValue = values[1];
return new Cookie(cookieName, cookieValue) { Domain = domain };
}
return null;
}
void AddHeader(HttpRequestHeaders headers, string headerName, string headerValue)
{
headers.TryAddWithoutValidation(headerName, headerValue);
Expand Down
27 changes: 26 additions & 1 deletion dotnet/test/DotNetUnitTest/Domain/GxHttpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public void AddHeaderWithSpecialCharactersDoesNotThrowException()
httpclient.Execute("GET", string.Empty);
Assert.NotEqual(((int)HttpStatusCode.InternalServerError), httpclient.StatusCode);
}

}

[Fact]
Expand All @@ -45,6 +44,32 @@ public void HttpClientInvalidURLWithCustomPort()
Assert.NotEqual(((int)HttpStatusCode.InternalServerError), httpclient.StatusCode);
}
}

[Fact]
public void HttpClientCookieHeader()
{
string headerValue = "CognitoIdentityServiceProvider.3tgmin25m9bkg6vgi7vpavu7a9.M00000936.refreshToken=eyJjdHkiOiJKV1QiLCJlbmMiSkRCAmMpYqndvORnWLTfHw; CognitoIdentityServiceProvider.3tgmin25m9bkg6vgi7vpavu7a9.LastAuthUser=M00000936";
string headerName = "Cookie";
using (GxHttpClient httpclient = new GxHttpClient())
{
httpclient.AddHeader(headerName, headerValue);
httpclient.Host = "localhost";
httpclient.Port = 80;
httpclient.BaseURL = @"NotFound/NotFound.php";
httpclient.HttpClientExecute("GET", string.Empty);
Assert.NotEqual(((int)HttpStatusCode.InternalServerError), httpclient.StatusCode);
}
using (GxHttpClient oldHttpclient = new GxHttpClient())
{
oldHttpclient.AddHeader(headerName, headerValue);
oldHttpclient.Host = "localhost";
oldHttpclient.Port = 80;
oldHttpclient.BaseURL = @"NotFound/NotFound.php";
oldHttpclient.Execute("GET", string.Empty);
Assert.NotEqual(((int)HttpStatusCode.InternalServerError), oldHttpclient.StatusCode);
}

}
#if !NETCORE
[Fact]
public void NoStoreHeader()
Expand Down