Skip to content

Fixed path resolution in HttpClient.ToFile for relative file names in web context #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed path resolution in HttpClient.ToFile for relative file names in web context #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7359f2b
Fixed path resolution in HttpClient.ToFile for relative file names in…
Oct 6, 2025
6f46e52
Change file existence check in GxHttpClientTest
claudiamurialdo Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/dotnetframework/GxClasses/Domain/GxHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,7 +2001,7 @@ public void ToFile(string fileName)
#if !NETCORE
if (HttpContext.Current != null)
#endif
if (fileName.IndexOfAny(new char[] { '\\', ':' }) == -1)
if (!Path.IsPathRooted(fileName))
pathName = Path.Combine(GxContext.StaticPhysicalPath(), fileName);

if (ReceiveData != null)
Expand Down
13 changes: 13 additions & 0 deletions dotnet/test/DotNetUnitTest/Domain/GxHttpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,19 @@ public void HttpClientCookiesTest()

}

[Fact]
public void ToRelativeFile()
{
using (GxHttpClient client = new GxHttpClient())
{
client.Host = "localhost";
client.BaseURL = "/dummy/lem.txt";
client.Execute("GET", string.Empty);
client.ToFile("./lem.txt");
Assert.True(File.Exists(Path.Combine(GxContext.StaticPhysicalPath(), "lem.txt")), $"HttpClient.ToFile failed to create the file at path: {GxContext.StaticPhysicalPath()}");
}
}

#if !NETCORE
[Fact]
public void NoStoreHeader()
Expand Down
Loading