-
Notifications
You must be signed in to change notification settings - Fork 12
Check for in-use resource when working with GXFile #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
claudiamurialdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
claudiamurialdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry pick to beta success |
| { | ||
| try | ||
| { | ||
| public void OpenWriteWithRetry(string encoding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain the original method signature "OpenWrite", as it is invoked by generated code.
| { | ||
| try | ||
| { | ||
| public void OpenReadWithRetry(string encoding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain the original method signature "OpenRead", as it is invoked by generated code.
Issue:203334