Skip to content

Conversation

@tomas-sexenian
Copy link
Contributor

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

Copy link
Collaborator

@claudiamurialdo claudiamurialdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

claudiamurialdo
claudiamurialdo previously approved these changes Feb 4, 2025
Copy link
Collaborator

@claudiamurialdo claudiamurialdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

{
try
{
public void OpenWriteWithRetry(string encoding)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain the original method signature "OpenWrite", as it is invoked by generated code.

{
try
{
public void OpenReadWithRetry(string encoding)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain the original method signature "OpenRead", as it is invoked by generated code.

@tomas-sexenian tomas-sexenian merged commit cafa188 into master Feb 19, 2025
9 checks passed
@tomas-sexenian tomas-sexenian deleted the file-share branch February 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants