Skip to content

Commit ea24e8e

Browse files
author
Gonzalo Gallotti Vazquez
committed
Add S3_SKIP_URL_SIGNATURE_TEST environment variable to skip URL signature tests in External Storage Tests
1 parent 07e3769 commit ea24e8e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.github/workflows/External-Storage-Tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ jobs:
7676
STORAGE_AWSS3_FOLDER_NAME: "gxclasses"
7777
STORAGE_AWSS3_REGION: "us-east-1"
7878
STORAGE_AWSS3_ENDPOINT: "custom"
79+
S3_SKIP_URL_SIGNATURE_TEST: "true"
7980
STORAGE_AWSS3_CUSTOM_ENDPOINT: "http://localhost:4566"
8081
IBMCOS_TEST_ENABLED: "true"
8182
STORAGE_IBMCOS_ACCESS_KEY: "${{ secrets.IBMCOS_ACCESS_KEY }}"

dotnet/test/DotNetUnitTest/ExternalProvider/ExternalProviderTest.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,15 @@ private static void Wait(int milliseconds)
393393
private void EnsureUrl(String signedOrUnsignedUrl, GxFileType acl)
394394
{
395395
Assert.True(UrlExists(signedOrUnsignedUrl), "URL not found: " + signedOrUnsignedUrl);
396-
if (IsPrivateFile(acl))
396+
397+
bool skipUrlSignatureTests = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("S3_SKIP_URL_SIGNATURE_TEST"));
398+
if (skipUrlSignatureTests)
397399
{
400+
return;
401+
}
402+
403+
if (IsPrivateFile(acl))
404+
{
398405
if (!(this is ExternalProviderMinioTest)) //Minio local installation not supported
399406
{
400407
Skip.If(this is ExternalProviderMinioTest);

0 commit comments

Comments
 (0)