Avoid printing duplicate messages when deserializing an invalid JSON

Author: claudiamurialdo

dotnet/src/dotnetframework/GxClasses/Core/GXUtilsCommon.cs

@@ -5455,15 +5455,22 @@ public static void ErrorToMessages(string errorId, string errorDescription, GXBa
 			}
 		}
 		public static void ErrorToMessages(string errorId, Exception ex, GXBaseCollection<SdtMessages_Message> Messages)
+		{
+			ErrorToMessages(errorId, ex, Messages, true);
+		}
+		internal static void ErrorToMessages(string errorId, Exception ex, GXBaseCollection<SdtMessages_Message> Messages, bool parseInnerExceptions)
 		{
 			if (Messages != null && ex != null)
 			{
 				StringBuilder str = new StringBuilder();
 				str.Append(ex.Message);
-				while (ex.InnerException != null)
+				if (parseInnerExceptions)
 				{
-					str.Append(ex.InnerException.Message);
-					ex = ex.InnerException;
+					while (ex.InnerException != null)
+					{
+						str.Append(ex.InnerException.Message);
+						ex = ex.InnerException;
+					}
 				}
 				ErrorToMessages(errorId, str.ToString(), Messages);
 			}

dotnet/src/dotnetframework/GxClasses/Domain/GxCollections.cs

@@ -238,7 +238,7 @@ public bool FromJSonString(string s, GXBaseCollection<SdtMessages_Message> Messa
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				return false;
 			}
 		}
@@ -709,7 +709,7 @@ public bool FromJSonString(string s, GXBaseCollection<SdtMessages_Message> Messa
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				return false;
 			}
 		}
@@ -1270,7 +1270,7 @@ public bool FromJSonString(string s, GXBaseCollection<SdtMessages_Message> Messa
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				return false;
 			}
 		}

dotnet/src/dotnetframework/GxClasses/Domain/GxGenericCollections.cs

@@ -472,7 +472,7 @@ public bool FromJSonString(string s, GXBaseCollection<SdtMessages_Message> Messa
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				return false;
 			}
 		}

dotnet/src/dotnetframework/GxClasses/Helpers/JSONHelper.cs

@@ -185,7 +185,7 @@ public static T ReadJSON<T>(string json, GXBaseCollection<SdtMessages_Message> M
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				GXLogging.Error(log, "FromJsonError ", ex);
 				return default(T);
 			}
@@ -207,7 +207,7 @@ public static T ReadJavascriptJSON<T>(string json, GXBaseCollection<SdtMessages_
 			}
 			catch (Exception ex)
 			{
-				GXUtil.ErrorToMessages("FromJson Error", ex, Messages);
+				GXUtil.ErrorToMessages("FromJson Error", ex, Messages, false);
 				GXLogging.Error(log, "FromJsonError ", ex);
 				return default(T);
 			}

dotnet/test/DotNetCoreUnitTest/StringUtil/JsonUtilTest.cs

@@ -13,6 +13,21 @@ namespace xUnitTesting
 {
 	public class JsonUtilTest
 	{
+		[Fact]
+		public void DeserializationInvalidJsonNoDuplicateError()
+		{
+			string invalidJson1 = "{\"id\":1,\"name\":\"uno\",\"date\":\"2016-02-24\"'";
+			GXBaseCollection<SdtMessages_Message> messages = new GXBaseCollection<SdtMessages_Message>();
+			JSONHelper.ReadJSON<JObject>(invalidJson1, messages);
+			string errMessage = messages.ToJSonString();
+#if NETCORE
+			string expectedError = "[{\"Id\":\"FromJson Error\",\"Type\":1,\"Description\":\"''' is invalid after a value. Expected either ',', '}', or ']'. Path: $.date | LineNumber: 0 | BytePositionInLine: 40.\"}]";
+#else
+			string expectedError = "[{\"Id\":\"FromJson Error\",\"Type\":1,\"Description\":\"Expected a ',' or '}'.\"}]";
+#endif
+			Assert.Equal(expectedError, errMessage);
+		}
+
 		[Fact]
 		public void SerializationWithDateTimes()
 		{