Ensure batch context is used only for batch processes (#1120)

* Ensure static _currentGxContext used for batch process is not accessed from a web app or http service.

* Keep compatibility in .net framework, when there is no current context in web application it must return null.
An error NullReferenceException was thrown by GxWebServicesConfig because GxContext.Current.SoapContext was null.

public object AfterReceiveRequest(ref System.ServiceModel.Channels.Message request, IClientChannel channel, InstanceContext instanceContext)
{
    GxHelpers.GetSoapContext().AppendXml(request.ToString());
    GxHelpers.GetSoapContext().EndMessage();
    return null;
}

* Initialize HttpContext on GxContext.

* Ensure consistent behavior with .NET Framework when retrieving the current GxContext.

Author: claudiamurialdo

dotnet/src/dotnetcore/GxNetCoreStartup/Startup.cs

@@ -431,11 +431,12 @@ private void ConfigureSessionService(IServiceCollection services, ISessionServic
 				});
 			}
 		}
-		public void Configure(IApplicationBuilder app, Microsoft.AspNetCore.Hosting.IHostingEnvironment env, ILoggerFactory loggerFactory)
+		public void Configure(IApplicationBuilder app, Microsoft.AspNetCore.Hosting.IHostingEnvironment env, ILoggerFactory loggerFactory, IHttpContextAccessor contextAccessor)
 		{
 			string baseVirtualPath = string.IsNullOrEmpty(VirtualPath) ? VirtualPath : $"/{VirtualPath}";
 			LogConfiguration.SetupLog4Net();
-			
+			AppContext.Configure(contextAccessor);
+
 			var provider = new FileExtensionContentTypeProvider();
 			//mappings
 			provider.Mappings[".json"] = "application/json";

dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs

@@ -284,6 +284,16 @@ public interface IGxContext
 		string GetURLBuildNumber(string resourcePath, string urlBuildNumber);
 	}
 #if NETCORE
+	internal static class AppContext
+	{
+		static IHttpContextAccessor _httpContextAccessor { get; set; }
+		internal static HttpContext Current => _httpContextAccessor != null ? new GxHttpContextAccesor(_httpContextAccessor) : null;
+		internal static void Configure(IHttpContextAccessor accessor)
+		{
+			_httpContextAccessor = accessor;
+		}
+
+	}
 	public class GxHttpContextAccesor : HttpContext
 	{
 		IHttpContextAccessor ctxAccessor;
@@ -603,11 +613,12 @@ public CookieContainer GetCookieContainer(string url, bool includeCookies = true
 		}
 
 		[NonSerialized]
-		static GxContext _currentGxContext;
+		static GxContext _currentBatchGxContext;
 		static public GxContext Current
 		{
 			get
 			{
+
 #if !NETCORE
 				if (HttpContext.Current != null)
 				{
@@ -619,11 +630,21 @@ static public GxContext Current
 				else
 				{
 
-					return _currentGxContext;
+					return _currentBatchGxContext;
 				}
 				return null;
 #else
-				return _currentGxContext;
+				if (AppContext.Current != null)
+				{
+					GxContext currCtx = (GxContext)AppContext.Current.Items["CURRENT_GX_CONTEXT"];
+					if (currCtx != null)
+						return currCtx;
+				}
+				else
+				{
+					return _currentBatchGxContext;
+				}
+				return null;
 #endif
 			}
 		}
@@ -632,9 +653,14 @@ static void setContext(GxContext ctx)
 #if !NETCORE
 			if (HttpContext.Current != null)
 				HttpContext.Current.Items["CURRENT_GX_CONTEXT"] = ctx;
-			else
+			
+#else
+			if (AppContext.Current != null)
+				AppContext.Current.Items["CURRENT_GX_CONTEXT"] = ctx;
 #endif
-				_currentGxContext = ctx;
+
+			else if (!IsHttpContext)
+				_currentBatchGxContext = ctx; 
 		}
 
 		public LocalUtil localUtil
@@ -1175,7 +1201,12 @@ public HttpContext HttpContext
 		{
 			get
 			{
-#if !NETCORE
+#if NETCORE
+				if (_HttpContext == null && AppContext.Current != null)
+				{
+					HttpContext = AppContext.Current;
+				}
+#else
 				if (_HttpContext == null && HttpContext.Current != null)
 				{
 					HttpContext = HttpContext.Current;