Skip to content

Commit ada6844

Browse files
Remove revision number from version for HotFixes (#785)
* Remove revision number from version for HotFixes (it is the same as build number) * Simplify FileVersion (drop Revision number altogether) * Fix GetFileVersionForPackage target --------- Co-authored-by: José Echagüe <jechague@genexus.com> (cherry picked from commit 63fe35e)
1 parent fd1ce0c commit ada6844

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

dotnet/Directory.Build.props

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@
44
<MajorFileVersion>1</MajorFileVersion>
55
<MajorFileVersion Condition="$(GIT_REF.EndsWith('beta'))">$([MSBuild]::Add($(MajorFileVersion), 100))</MajorFileVersion>
66
<MinorFileVersion>18</MinorFileVersion>
7-
<RevisionFileVersion Condition="'$(COMMIT_NUMBER)'!=''">$(COMMIT_NUMBER)</RevisionFileVersion>
8-
<RevisionFileVersion Condition="'$(COMMIT_NUMBER)'==''">0</RevisionFileVersion>
9-
<FileVersionWithoutRevision>$(MajorFileVersion).$(MinorFileVersion).$(RevisionFileVersion)</FileVersionWithoutRevision>
10-
<FileVersionWithoutRevision Condition="$(GIT_REF.EndsWith('beta')) Or $(GIT_REF.EndsWith('master'))">$(MajorFileVersion).$(MinorFileVersion).0</FileVersionWithoutRevision>
11-
<FileVersion>$(FileVersionWithoutRevision).$(RevisionFileVersion)</FileVersion>
7+
<PatchFileVersion Condition="'$(COMMIT_NUMBER)'!=''">$(COMMIT_NUMBER)</PatchFileVersion>
8+
<PatchFileVersion Condition="'$(COMMIT_NUMBER)'==''">0</PatchFileVersion>
9+
<FileVersion>$(MajorFileVersion).$(MinorFileVersion).$(PatchFileVersion)</FileVersion>
1210
<InformationalVersion>$([System.DateTime]::UtcNow.ToString("yyyyMMddHHmmss")).$(GIT_SHA)</InformationalVersion>
1311
<Company>GeneXus</Company>
1412
<AssemblyCulture></AssemblyCulture>
@@ -41,6 +39,6 @@
4139
</PropertyGroup>
4240

4341
<Target Name="GetFileVersionForPackage">
44-
<Message Importance="high" Text="FileVersion:$(FileVersionWithoutRevision)"></Message>
42+
<Message Importance="high" Text="FileVersion:$(FileVersion)"></Message>
4543
</Target>
4644
</Project>

0 commit comments

Comments
 (0)