Fix CA2022: Avoid inexact read with Stream.Read (#1080)

claudiamurialdo · claudiamurialdo · commit a461cfbf55f2 · 2025-01-14T11:40:39.000-03:00
* Fix CA2022: Avoid inexact read with Stream.Read * Change fix to CA2022 (cherry picked from commit 57f0e43)
diff --git a/dotnet/src/dotnetframework/GxClasses/Domain/GxFtp.cs b/dotnet/src/dotnetframework/GxClasses/Domain/GxFtp.cs
@@ -847,9 +847,9 @@ private bool IsCompleteResponse(Stream responseStream)
 			{
 				int StatusCode=-1;									
 				Byte[] ByteArray = new Byte[responselength];			
-				String statuscodestr;							
-				responseStream.Read(ByteArray,0,responselength);		
-				statuscodestr=Encoding.ASCII.GetString(ByteArray,0,responselength);			
+				String statuscodestr;
+				int bytesRead = responseStream.Read(ByteArray, 0, responselength);
+				statuscodestr = Encoding.ASCII.GetString(ByteArray,0, bytesRead);			
 				if (responselength==5 && ByteArray[responselength-1] == '\n')	
 				{
 					

Original file line number	Diff line number	Diff line change
`@@ -847,9 +847,9 @@ private bool IsCompleteResponse(Stream responseStream)`
`847`	`847`	`{`
`848`	`848`	`int StatusCode=-1;`
`849`	`849`	`Byte[] ByteArray = new Byte[responselength];`
`850`		`- String statuscodestr;`
`851`		`- responseStream.Read(ByteArray,0,responselength);`
`852`		`- statuscodestr=Encoding.ASCII.GetString(ByteArray,0,responselength);`
	`850`	`+ String statuscodestr;`
	`851`	`+ int bytesRead = responseStream.Read(ByteArray, 0, responselength);`
	`852`	`+ statuscodestr = Encoding.ASCII.GetString(ByteArray,0, bytesRead);`
`853`	`853`	`if (responselength==5 && ByteArray[responselength-1] == '\n')`
`854`	`854`	`{`
`855`	`855`