Do not check encryption in variables that we know are not encrypted, and also, it is not necessary to read Env variables for them.

Author: sjuarezgx

dotnet/src/dotnetcore/Providers/Messaging/GXAzureServiceBus/AzureServiceBus.cs

@@ -46,16 +46,16 @@ private void Initialize(GXService providerService)
 			_connectionString = serviceSettings.GetEncryptedPropertyValue(PropertyConstants.QUEUE_CONNECTION_STRING);
 			_subscriptionName = serviceSettings.GetEncryptedPropertyValue(PropertyConstants.TOPIC_SUBSCRIPTION);
 			_fullyqualifiedNamespace = serviceSettings.GetEncryptedPropertyValue(PropertyConstants.FULLYQUALIFIEDNAMESPACE);
-			string authenticationMethod = serviceSettings.GetEncryptedPropertyValue(PropertyConstants.AUTHENTICATION_METHOD);
+			string authenticationMethod = serviceSettings.GetPropertiesValue(PropertyConstants.AUTHENTICATION_METHOD);
 
-			string sessionEnabled = serviceSettings.GetEncryptedOptPropertyValue(PropertyConstants.SESSION_ENABLED);
+			string sessionEnabled = serviceSettings.GetPropertiesValue(PropertyConstants.SESSION_ENABLED);
 
 			if (!string.IsNullOrEmpty(sessionEnabled))
 				_sessionEnabled = Convert.ToBoolean(sessionEnabled);
 			else
 				_sessionEnabled = false;
 
-			string senderIdentifier = serviceSettings.GetEncryptedOptPropertyValue(PropertyConstants.SENDER_IDENTIFIER);
+			string senderIdentifier = serviceSettings.GetPropertiesValue(PropertyConstants.SENDER_IDENTIFIER);
 
 			ServiceBusSenderOptions serviceBusSenderOptions = new ServiceBusSenderOptions();
 			if (!string.IsNullOrEmpty(senderIdentifier))
@@ -82,9 +82,9 @@ private void Initialize(GXService providerService)
 				{
 					_serviceBusReceiverOptions = new ServiceBusReceiverOptions();
 
-					string receiveMode = serviceSettings.GetEncryptedOptPropertyValue(PropertyConstants.RECEIVE_MODE);
-					string prefetchCount = serviceSettings.GetEncryptedOptPropertyValue(PropertyConstants.PREFETCH_COUNT);
-					string receiverIdentifier = serviceSettings.GetEncryptedOptPropertyValue(PropertyConstants.RECEIVER_IDENTIFIER);
+					string receiveMode = serviceSettings.GetPropertiesValue(PropertyConstants.RECEIVE_MODE);
+					string prefetchCount = serviceSettings.GetPropertiesValue(PropertyConstants.PREFETCH_COUNT);
+					string receiverIdentifier = serviceSettings.GetPropertiesValue(PropertyConstants.RECEIVER_IDENTIFIER);
 
 					if (!string.IsNullOrEmpty(receiveMode))
 						_serviceBusReceiverOptions.ReceiveMode = (ServiceBusReceiveMode)Convert.ToInt16(receiveMode);

dotnet/src/dotnetcore/Providers/Messaging/GXMessageBroker/MessageBrokerProvider.cs

@@ -75,8 +75,7 @@ private static void Preprocess(string name, GXProperties properties)
 					SetEncryptedProperty(properties, PropertyConstants.MESSAGEBROKER_AZURESB_QUEUENAME);
 					SetEncryptedProperty(properties, PropertyConstants.MESSAGEBROKER_AZURESB_SUBSCRIPTION_NAME);
 					SetEncryptedProperty(properties, PropertyConstants.MESSAGEBROKER_AZURESB_CONNECTIONSTRING);
-					SetEncryptedProperty(properties, PropertyConstants.MESSAGEBROKER_AZURESB_FULLYQUALIFIEDNAMESPACE);
-					SetEncryptedProperty(properties, PropertyConstants.AUTHENTICATION_METHOD);
+					SetEncryptedProperty(properties, PropertyConstants.MESSAGEBROKER_AZURESB_FULLYQUALIFIEDNAMESPACE);				
 					if (string.IsNullOrEmpty(providerService.ClassName) || !providerService.ClassName.Contains(className))
 					{
 						providerService.ClassName = PropertyConstants.AZURE_SB_PROVIDER_CLASSNAME;

dotnet/src/dotnetcore/Providers/Messaging/GXMessageBroker/ServiceSettings.cs

@@ -20,10 +20,9 @@ public ServiceSettings(string serviceNameResolver, string name, GXService gXServ
 			service = gXService;
 		}
 
-		public string GetEncryptedOptPropertyValue(string propertyName, string alternativePropertyName = null)
+		public string GetPropertiesValue(string propertyName)
 		{
-			string value = GetEncryptedPropertyValue(propertyName, alternativePropertyName, null);		
-			return value;
+			return service.Properties.Get(propertyName);
 		}
 		public string GetEncryptedPropertyValue(string propertyName, string alternativePropertyName = null)
 		{