Specify event name on Parameter Mismatch Error Message

Author: claudiamurialdo

dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs

@@ -3173,7 +3173,7 @@ public void ExecuteBeforeCommit(string callerName)
 			{
 				inBeforeCommit = true;
 				if (beforeCommitObj != null)
-					ClassLoader.ExecuteVoidRef(beforeCommitObj, "execute", new Object[] { callerName });
+					ClassLoader.ExecuteVoidRef(beforeCommitObj, "execute", new Object[] { callerName }, "Before Commit");
 				inBeforeCommit = false;
 			}
 		}
@@ -3184,7 +3184,7 @@ public void ExecuteAfterCommit(string callerName)
 			{
 				inAfterCommit = true;
 				if (afterCommitObj != null)
-					ClassLoader.ExecuteVoidRef(afterCommitObj, "execute", new Object[] { callerName });
+					ClassLoader.ExecuteVoidRef(afterCommitObj, "execute", new Object[] { callerName },"After Commit");
 				inAfterCommit = false;
 			}
 		}
@@ -3195,7 +3195,7 @@ public void ExecuteBeforeRollback(string callerName)
 			{
 				inBeforeRollback = true;
 				if (beforeRollbackObj != null)
-					ClassLoader.ExecuteVoidRef(beforeRollbackObj, "execute", new Object[] { callerName });
+					ClassLoader.ExecuteVoidRef(beforeRollbackObj, "execute", new Object[] { callerName }, "Before Rollback");
 				inBeforeRollback = false;
 			}
 		}
@@ -3206,7 +3206,7 @@ public void ExecuteAfterRollback(string callerName)
 			{
 				inAfterRollback = true;
 				if (afterRollbackObj != null)
-					ClassLoader.ExecuteVoidRef(afterRollbackObj, "execute", new Object[] { callerName });
+					ClassLoader.ExecuteVoidRef(afterRollbackObj, "execute", new Object[] { callerName }, "After Rollback");
 				inAfterRollback = false;
 			}
 		}
@@ -3216,7 +3216,7 @@ public bool ExecuteBeforeConnect(IGxDataStore datastore)
 			if (beforeConnectObj != null)
 			{
 				GXLogging.Debug(log, "ExecuteBeforeConnect");
-				ClassLoader.ExecuteVoidRef(beforeConnectObj, "execute", new Object[] { datastore });
+				ClassLoader.ExecuteVoidRef(beforeConnectObj, "execute", new Object[] { datastore }, "Before Connect");
 				return true;
 			}
 			else
@@ -3230,7 +3230,7 @@ public bool ExecuteAfterConnect(String datastoreName)
 			if (afterConnectObj != null)
 			{
 				GXLogging.Debug(log, "ExecuteAfterConnect");
-				ClassLoader.ExecuteVoidRef(afterConnectObj, "execute", new Object[] { datastoreName });
+				ClassLoader.ExecuteVoidRef(afterConnectObj, "execute", new Object[] { datastoreName }, "After Connect");
 				return true;
 			}
 			else

dotnet/src/dotnetframework/GxClasses/Helpers/GXMetadata.cs

@@ -232,8 +232,11 @@ internal static string ConstructorArgsString(Object[] constructorArgs)
 			}
 			return argsConstr;
 		}
-
 		static public void ExecuteVoidRef(object o, string mthd, Object[] args)
+		{
+			ExecuteVoidRef(o, mthd, args, null);
+		}
+		internal static void ExecuteVoidRef(object o, string mthd, Object[] args, string propertyName)
 		{
 			try
 			{
@@ -279,7 +282,7 @@ static public void ExecuteVoidRef(object o, string mthd, Object[] args)
 
 						}catch(MissingMethodException)
 						{
-							throw new GxClassLoaderException(BuildParameterMismatchErrorMessage(mi.DeclaringType.FullName, pis, args));
+							throw new GxClassLoaderException(BuildParameterMismatchErrorMessage(mi.DeclaringType.FullName, pis, args, propertyName));
 						}
 					}
 					else
@@ -296,35 +299,38 @@ static public void ExecuteVoidRef(object o, string mthd, Object[] args)
 				throw GxClassLoaderException.ProcessException(e);
 			}
 		}
-		static string BuildParameterMismatchErrorMessage(string objectName, ParameterInfo[] methodParameters, object[] runtimeMethodParameters)
+		static string BuildParameterMismatchErrorMessage(string objectName, ParameterInfo[] methodParameters, object[] runtimeMethodParameters, string propertyName)
 		{
 			string parmInfo = GetParameterTypesString(methodParameters);
 			string runtimeParms = GetParameterValuesString(runtimeMethodParameters);
 			StringBuilder errorMessage = new StringBuilder();
-			if (methodParameters.Length == 0)
+
+			errorMessage.Append($"Program {objectName} ");
+			if (!string.IsNullOrEmpty(propertyName))
 			{
-				errorMessage.Append($"The object {objectName} does not have any parameters, thus it does not match the ");
+				errorMessage.Append($"referenced in {propertyName} property ");
 			}
-			else if (methodParameters.Length == 1)
+			errorMessage.Append($"does not have the expected parameter definition.");
+			if (methodParameters.Length == 0)
 			{
-				errorMessage.Append($"The parm rule of {objectName} with parameter: {parmInfo} does not match the ");
+				errorMessage.Append($"It does not have any parameters.");
 			}
-			else
+			else 
 			{
-				errorMessage.Append($"The parm rule of {objectName} with parameters: {parmInfo} does not match the ");
+				errorMessage.Append($"Program parameter definition: {parmInfo}.");
 			}
 
 			if (runtimeMethodParameters.Length == 0)
 			{
-				errorMessage.Append($"absence of values provided at runtime. ");
+				errorMessage.Append($"No parameter values were provided at runtime. ");
 			}
 			else if (runtimeMethodParameters.Length == 1)
 			{
-				errorMessage.Append($"value provided in runtime: {runtimeParms}. ");
+				errorMessage.Append($"Parameter value provided at runtime: {runtimeParms}. ");
 			}
 			else
 			{
-				errorMessage.Append($"values provided in runtime: {runtimeParms}. ");
+				errorMessage.Append($"Parameter values provided at runtime: {runtimeParms}. ");
 			}
 			errorMessage.Append($"Please check the parm rule of the {objectName}.");