Skip to content

Commit 2f5fafb

Browse files
Keep COMMIT_NUMBER local var as a msbuild parameter given that GITHUB_ENV var are not seen by the step that defined the var.
It should be set a power shell var instead of a local var ( $Env:COMMIT_NUMBER = @($(git....) or keep msbuild explicit parameter /p:COMMIT_NUMBER=$COMMIT_NUMBER
1 parent 6c7527a commit 2f5fafb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/Build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ jobs:
8181
$COMMIT_MESSAGE = $(git log -1 --pretty=%B)
8282
$LAST_COMMITTER = $(git log -1 --pretty=format:%an)
8383
84-
echo "COMMIT_NUMBER=$COMMIT_NUMBER" >> $env:GITHUB_ENV
85-
$GetFileVersionOutput = dotnet msbuild dotnet/Directory.Build.props /t:GetFileVersionForPackage
84+
$GetFileVersionOutput = dotnet msbuild dotnet/Directory.Build.props /t:GetFileVersionForPackage /p:COMMIT_NUMBER=$COMMIT_NUMBER
8685
"$GetFileVersionOutput" -match "(?<=FileVersion:)(.*)" > $null
8786
$GetFileVersionOutput = $Matches[0]
8887
@@ -97,6 +96,7 @@ jobs:
9796
Write-Output "Packge version to be used: $NUGET_PACKAGE_VERSION"
9897
9998
echo "NUGET_PACKAGE_VERSION=$NUGET_PACKAGE_VERSION" >> $env:GITHUB_ENV
99+
echo "COMMIT_NUMBER=$COMMIT_NUMBER" >> $env:GITHUB_ENV
100100
echo "IsPrerelease=$IsPrerelease" >> $env:GITHUB_ENV
101101
102102
echo "::set-output name=NUGET_PACKAGE_VERSION::$NUGET_PACKAGE_VERSION"

0 commit comments

Comments
 (0)