GetNextUID was not working for POP3SessionOpenPop. (#819)

claudiamurialdo · claudiamurialdo · commit 1b31b9ee8ef5 · 2023-05-27T08:36:24.000-03:00
(cherry picked from commit 852481b)
diff --git a/dotnet/src/dotnetframework/GxMail/POP3SessionOpenPop.cs b/dotnet/src/dotnetframework/GxMail/POP3SessionOpenPop.cs
@@ -35,7 +35,6 @@ public override void Login(GXPOP3Session sessionInfo)
                 client.Authenticate(UserName, Password, OpenPop.Pop3.AuthenticationMethod.Auto);
                 count = client.GetMessageCount();
                 uIds = client.GetMessageUids();
-                uIds.Insert(0, string.Empty);
             }
             catch (PopServerNotAvailableException e)
             {
diff --git a/dotnet/src/dotnetframework/GxMail/Pop3MailKit.cs b/dotnet/src/dotnetframework/GxMail/Pop3MailKit.cs
@@ -58,7 +58,6 @@ public override void Login(GXPOP3Session sessionInfo)
 					BasicAuth(_sessionInfo, client);
 				count = client.Count;
 				uIds = (List<string>)client.GetMessageUids();
-				/*uIds.Insert(0, string.Empty);*/
 
 			}
 			catch (NotSupportedException e)
diff --git a/dotnet/src/dotnetframework/GxMail/Pop3SessionBase.cs b/dotnet/src/dotnetframework/GxMail/Pop3SessionBase.cs
@@ -54,7 +54,7 @@ public virtual string GetNextUID(GXPOP3Session session)
 			if (lastReadMessage == count)
 			{
 				LogDebug("No messages to receive", "No messages to receive", MailConstants.MAIL_NoMessages, log);
-				return "";
+				return string.Empty;
 			}
 			int nextMessage = lastReadMessage + 1;
 			int zeroBasedIndexForNextMessage = nextMessage - 1;

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ public override void Login(GXPOP3Session sessionInfo)`
`35`	`35`	`client.Authenticate(UserName, Password, OpenPop.Pop3.AuthenticationMethod.Auto);`
`36`	`36`	`count = client.GetMessageCount();`
`37`	`37`	`uIds = client.GetMessageUids();`
`38`		`- uIds.Insert(0, string.Empty);`
`39`	`38`	`}`
`40`	`39`	`catch (PopServerNotAvailableException e)`
`41`	`40`	`{`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ public override void Login(GXPOP3Session sessionInfo)`
`58`	`58`	`BasicAuth(_sessionInfo, client);`
`59`	`59`	`count = client.Count;`
`60`	`60`	`uIds = (List<string>)client.GetMessageUids();`
`61`		`- /uIds.Insert(0, string.Empty);/`
`62`	`61`
`63`	`62`	`}`
`64`	`63`	`catch (NotSupportedException e)`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public virtual string GetNextUID(GXPOP3Session session)`
`54`	`54`	`if (lastReadMessage == count)`
`55`	`55`	`{`
`56`	`56`	`LogDebug("No messages to receive", "No messages to receive", MailConstants.MAIL_NoMessages, log);`
`57`		`- return "";`
	`57`	`+ return string.Empty;`
`58`	`58`	`}`
`59`	`59`	`int nextMessage = lastReadMessage + 1;`
`60`	`60`	`int zeroBasedIndexForNextMessage = nextMessage - 1;`