[ENH] Convert InterpolationOptions to Pydantic model #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Leguark
changed the title
Replaced direct instantiation of `InterpolationOptions` with the `from_args` class method across multiple modules and tests for consistency and improved clarity. Updated related examples and fixtures to align with this change.
…I. I hate python refactoring
Added validation logic for `kernel_function` fields to ensure proper deserialization from string inputs to enums. Enhanced default JSON serialization by including additional encoders and adjusted relevant field exclusions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the first example of InterpolationOptions serializable
This PR converts the
InterpolationOptionsclass from a dataclass to a Pydantic model to enable serialization. The changes include:BaseModelforInterpolationOptionsfrom_args()to maintain backward compatibilityoctree_curvature_thresholdby adding a decimal pointTempInterpolationValuesa proper dataclassThese changes are the first step toward making the model serializable while maintaining the existing functionality.