Minor change: reset dataframe index for input data - #762
Merged
Merged
Conversation
Contributor
|
@adamchengtkc, that is a nice addition to GemPy. I avoided fixing the error that you experiencing to make sure that the user resets the index before passing the data to GemPy. |
Contributor
Author
|
Yep that can also work. But I would add catching the indexing error from Pandas and provide more explicit error message to the user on ways to fixing their code Feel free to close this without merge |
Japhiolite
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reset input Pandas df index when loading dataframe from
init_data()Currently if loading data from dataframe which has duplicated index, pandas will return indexing error. This fix indexing and make copy of the input dataframe (To maintain immutability of user input data)
Checklist
which are formatted per the Google Python Style Guidelines.
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).