[DOC] Warning of currently incomaptible pandas version and export functionality for shemat-suite #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Japhiolite
changed the title
|
Do you have an example of this that we can put as a test? |
|
sure thing. Will create one today |
previous docstring was "orientation values [dip, azimuth, polarity]" changed to "orientation values [azimuth, dip, polarity]" as first value is taken as azimuth and second as dip, not vice versa
this caused the categorial classification of pandas to raise a Type Error
this enables proper categorial classification by pandas
revert for today
add a warning in the init and the readme.
Japhiolite
changed the title
some weired matplotlib / pandas behaviour...
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit: Pandas version 1.4 caused massive problems for the gempy architecture. After looking into the issues raised, it was decided to have a more thorough overhaul in the near future.
For the time being, a warning is implemented in readme and init to red-flag the version problem for users.
In addition to the assertion for Pandas version, this PR fixes a bug, where interface points in
plot_2dwere plotted in greyscale. They're now correctly shown in the assigned gempy-colors. Relevant Issue #679From the old PR:
With SHEMAT-Suite being now open source, I dug up some old code I wrote for geomodeller models. Changed a bit here and there, so gempy voxel-models can now exported to a very basic SHEMAT-Suite input file.
Relates to
Checklist
which are formatted per the Google Python Style Guidelines.