Skip to content

Conversation

@talkenson
Copy link

No description provided.

@talkenson talkenson force-pushed the feat/add-dtl branch 4 times, most recently from 7195292 to cddccaf Compare June 10, 2025 07:18
@talkenson talkenson requested a review from shadowusr June 10, 2025 07:22
@talkenson talkenson marked this pull request as ready for review June 10, 2025 07:22
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts I have after taking a look:

  • Let's come up with a better configuration API. browser.configureDTL isn't a good choice for multiple reasons (you need browser instance to configure, naming feels off, you can't set this globally)

  • We need to check an important edge-case: what if users followed through with our docs and uses wdio-testing-library? Then if he updates, tests will be failing, because of duplicate commands. We need to check this

  • We need to check that timeouts for find* queries are being configured correctly. For example, how timeouts specified in our testplane config, interact with those. If they don't it's an issue, because they should affect testing-library timeouts.

@talkenson talkenson force-pushed the feat/add-dtl branch 2 times, most recently from a8d4910 to 7ecc7f7 Compare June 24, 2025 07:38
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I still see no signs that we respect timeouts set in testplane config in find* queries (see point 3 of my previous comment)

@talkenson
Copy link
Author

I think now it looks okay, but feel free to ask for more changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants