-
Notifications
You must be signed in to change notification settings - Fork 68
feat: add support of @testing-library/dom queries #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7195292 to
cddccaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts I have after taking a look:
-
Let's come up with a better configuration API.
browser.configureDTLisn't a good choice for multiple reasons (you need browser instance to configure, naming feels off, you can't set this globally) -
We need to check an important edge-case: what if users followed through with our docs and uses wdio-testing-library? Then if he updates, tests will be failing, because of duplicate commands. We need to check this
-
We need to check that timeouts for
find*queries are being configured correctly. For example, how timeouts specified in our testplane config, interact with those. If they don't it's an issue, because they should affect testing-library timeouts.
a8d4910 to
7ecc7f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I still see no signs that we respect timeouts set in testplane config in find* queries (see point 3 of my previous comment)
|
I think now it looks okay, but feel free to ask for more changes |
No description provided.