Skip to content

Commit 694065f

Browse files
authored
Merge branch 'main' into renovate/googleapis-genai-toolbox-0.x
2 parents 24ebecb + b4bc112 commit 694065f

File tree

4 files changed

+28
-6
lines changed

4 files changed

+28
-6
lines changed

.github/labels.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,8 @@
7979

8080
- name: 'status: waiting for response'
8181
color: 8befd7
82-
description: 'Status: reviewer is awaiting feedback or responses from the author before proceeding.'
82+
description: 'Status: reviewer is awaiting feedback or responses from the author before proceeding.'
83+
84+
- name: 'release-please:force-run'
85+
color: bdca82
86+
description: Manually trigger the release please workflow on a PR.

.github/workflows/assign-prs.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
name: PR assignment
1616

1717
on:
18-
pull_request:
19-
types: [opened, edited, synchronize, reopened]
18+
pull_request_target:
19+
types: [opened, edited, reopened]
2020

2121
jobs:
2222
auto-assign:
2323
runs-on: ubuntu-latest
2424
permissions:
25+
issues: write
2526
pull-requests: write
2627
steps:
2728
- name: "Auto-assign PR"

.github/workflows/mirror-changelog.yml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,26 @@ jobs:
8282
// Match and extract changelog item
8383
const itemMatch = trimmedLine.match(/^[*-]\s(.*)$/);
8484
if (itemMatch) {
85-
const originalContent = itemMatch[1];
85+
let originalContent = itemMatch[1];
86+
87+
// This is a two-step process to prevent `release-please` from
88+
// creating mangled, doubly-nested links for PRs.
89+
90+
// STEP 1: CLEAN THE INPUT.
91+
// The source changelog contains a zero-width space as an HTML entity (`​`).
92+
// This breaks the regex in the next step, so we must remove it first.
93+
// E.g., "[#​1770](...)" becomes "[#1770](...)"
94+
originalContent = originalContent.replace(/​/g, '');
95+
96+
// STEP 2: PROTECT THE OUTPUT.
97+
// `release-please` aggressively tries to auto-link any text that looks like `#1234`.
98+
// To prevent this, we insert an invisible Unicode zero-width space (`\u200B`)
99+
// between the '#' and the number in the link text. This breaks the parser's
100+
// pattern matching without changing the visual appearance of the link.
101+
// E.g., "[#1770](...)" becomes "[genai-toolbox#​1770](...)"
102+
originalContent = originalContent.replace(/\[#(\d+)\](\([^)]+\))/g, '[genai-toolbox#\u200B$1]$2');
103+
86104
const lineAsLowerCase = originalContent.toLowerCase();
87-
88105
const hasPrefix = prefixesToFilter.some(prefix => lineAsLowerCase.includes(prefix));
89106
90107
// Check if the line includes ANY of the required keywords

.github/workflows/presubmit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Install toolbox binary
3131
run: |
3232
VERSION=$(cat toolbox_version.txt)
33-
curl -L -o toolbox https://storage.googleapis.com/genai-toolbox/v$VERSION/linux/amd64/toolbox
33+
curl -L -o toolbox "https://storage.googleapis.com/genai-toolbox/v${VERSION}/linux/amd64/toolbox"
3434
chmod +x toolbox
3535
3636
- name: Install Extension

0 commit comments

Comments
 (0)