[sql] Fix non-normalized queries over native protocol #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries where we had to fall back to the non-normalized version were broken under the native protocol, because we were still feeding the arguments to postgres. Also, make `pg_get_serial_sequence` force non-normalization, since it ignores its arguments. It still fails if actual params are used, though.
elprans
approved these changes
Feb 6, 2025
msullivan
added
backported-6.x
msullivan
added a commit
that referenced
this pull request
Feb 6, 2025
Queries where we had to fall back to the non-normalized version were broken under the native protocol, because we were still feeding the arguments to postgres. Also, make `pg_get_serial_sequence` force non-normalization, since it ignores its arguments. It still fails if actual params are used, though.
deepbuzin
pushed a commit
that referenced
this pull request
Feb 18, 2025
Queries where we had to fall back to the non-normalized version were broken under the native protocol, because we were still feeding the arguments to postgres. Also, make `pg_get_serial_sequence` force non-normalization, since it ignores its arguments. It still fails if actual params are used, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries where we had to fall back to the non-normalized version were
broken under the native protocol, because we were still feeding the
arguments to postgres.
Also, make
pg_get_serial_sequenceforce non-normalization, since itignores its arguments. It still fails if actual params are used,
though.