Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to leave more backend connections free in test suite #8274

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Try to leave more backend connections free in test suite #8274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions edb/server/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,11 @@ def compute_default_max_backend_connections() -> int:

def adjust_testmode_max_connections(max_conns):
# Some test cases will start a second EdgeDB server (default
# max_backend_connections=10), so we should reserve some backend
# max_backend_connections=5), so we should reserve some backend
# connections for that. This is ideally calculated upon the edb test -j
# option, but that also depends on the total available memory. We are
# hard-coding 15 reserved connections here for simplicity.
return max(1, max_conns // 2, max_conns - 15)
return max(1, max_conns // 2, max_conns - 30)


def _validate_compiler_pool_size(ctx, param, value):
Expand Down
2 changes: 1 addition & 1 deletion edb/testbase/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2726,7 +2726,7 @@ def start_edgedb_server(
bind_addrs: tuple[str, ...] = ('localhost',),
auto_shutdown_after: Optional[int]=None,
bootstrap_command: Optional[str]=None,
max_allowed_connections: Optional[int]=10,
max_allowed_connections: Optional[int]=5,
compiler_pool_size: int=2,
compiler_pool_mode: Optional[edgedb_args.CompilerPoolMode] = None,
adjacent_to: Optional[tconn.Connection]=None,
Expand Down