Make linkprops (including @source/@target) work in conflict selects #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
approved these changes
May 1, 2024
| @@ -76,8 +76,9 @@ abstract link translated_label { | |||
|
|
|||
| abstract link link_with_unique_property { | |||
| property unique_property -> str { | |||
| constraint exclusive; | |||
| # constraint exclusive; | |||
Exclusive constraints on the linkprops themselves still don't work, though it should be fixable. Fixes #7263
elprans
approved these changes
May 1, 2024
vpetrovykh
added
the
backported-5.x
msullivan
added a commit
that referenced
this pull request
May 14, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
msullivan
added a commit
that referenced
this pull request
May 15, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
msullivan
added a commit
that referenced
this pull request
May 15, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
vpetrovykh
pushed a commit
that referenced
this pull request
May 21, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
The regression was introduced in #7284, which made `utils.subject_substitute` substitute `__subject__` in for the implicit path prefix. That fixed an issue in some cases, but introduced an extra level of Set/SelectStmt indirection in others. That level of indirection could cause us to emit redundant semijoins in some cases, which caused a major performance regression on UNLESS CONFLICT on object level exclusive constraints that referred to a link using a partial path prefix. (Referring to the link using `__subject__.` was already slow!) Fix that by making `subject_substitute` smarter. The redundant semi-join issue can come up in other cases too, like: ``` select (User, (User,).0.deck); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclusive constraints on the linkprops themselves still don't work,
though it should be fixable.
Fixes #7263