Gel sqla #536
Merged
Gel sqla #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetrovykh
force-pushed
the
gel-sqla
branch
2 times, most recently
from
0885a10 to
fd5217c
Compare
msullivan
reviewed
Nov 22, 2024
|
Could you post some generated code? |
msullivan
reviewed
Nov 22, 2024
msullivan
reviewed
Nov 22, 2024
vpetrovykh
force-pushed
the
gel-sqla
branch
3 times, most recently
from
8c0f82e to
aa57a94
Compare
vpetrovykh
force-pushed
the
gel-sqla
branch
3 times, most recently
from
6aa78ae to
61c9c75
Compare
Create separate intermediate objects to represent links with link properties (because ORMs tend to view them as such). Don't allow crazy names (not usual type of identifiers). Multi properties behave more like plain multi links than anything else (because they have a separate table with the property value in it), so they should be reflected like that establishing a relationship. Reflect Gel modules into Python modules. Add tests that setup a Gel database and then generate the SQLAlchemy models from it. The individual tests use a SQLAlchemy session to access the database using postgres protocol.
msullivan
reviewed
Dec 4, 2024
Comment on lines
+213
to
+226
| for bklinks in bk.values(): | ||
| if len(bklinks) > 1: | ||
| # We have a collision, so each backlink in it must now be | ||
| # disambiguated. | ||
| for link in bklinks: | ||
| origsrc = get_sql_name(link['target']['name']) | ||
| lname = link['name'] | ||
| link['name'] = f'{lname}_from_{origsrc}' | ||
| # Also update the original source of the link with the | ||
| # special backlink name. | ||
| source = type_map[link['target']['name']] | ||
| fwname = lname.replace('backlink_via_', '', 1) | ||
| link['fwname'] = fwname | ||
| source['backlink_renames'][fwname] = link['name'] |
There was a problem hiding this comment.
Could we always generate the disambiguated backlink, and then only generate the short name when it is unambiguous, or does that not work?
There was a problem hiding this comment.
We mostly expect not too many collisions so I tend to treat that as a the default. Backlink collisions appear when everything is linked to everything, which is not necessarily a common schema since that creates a lot of links to maintain.
Also, detecting unambiguous backlinks is a little more annoying that the other way around. Collisions are shown by identical names, but unambiguous long names would have to be checked by looking up their corresponding forward link name, seems more roundabout.
msullivan
approved these changes
Dec 4, 2024
| # have psycopg2 installed, as long as we run this in the test | ||
| # environments that have this, it is fine since we're not expecting | ||
| # different functionality based on flavours of psycopg2. | ||
| if importlib.util.find_spec("psycopg2") is None: |
There was a problem hiding this comment.
I think it would be cleaner to do
try:
import psychopg2
except ImportError:
# handle it
There was a problem hiding this comment.
I wanted to avoid the import since I don't even need anything from psycopg2 directly, not using it anywhere myself. Didn't want to leave the impression that I needed the import myself and if it's not used, maybe it's OK to "remove this dependency check" making it look like an outdated comment or dead code. importlib seemed like a more overt and unambiguous check.
Run `gel-orm --help` for more details.
msullivan
added a commit
that referenced
this pull request
Feb 23, 2025
EdgeDB has been renamed to Gel, and so has this python package. Changes ======= * Rename the package to gel! The package still provides an ``edgedb`` module in addition to ``gel``, but ``gel`` is now preferred. (by @msullivan in 83349d4 for #566) * Allow cloud instance names to contain '-' and '_' in the org part to support vercel instances (by @msullivan in 5b5be68 for #1084) * Support specifying SNI tls_server_name (by @msullivan in 6b28b98 for #1088) * Support GEL_ env vars and gel.toml (by @msullivan in d0b3961 for #532) * Add support for protocol 3.0 (by @elprans in 2e6a877 for #534) * Add support for newly exposed Postgres types (by @elprans in 48a67c1) * Kill pre-1.0 forever deprecated API / dead code. (by @1st1 in 8669e78) * Rename main module from edgedb to gel (by @msullivan in 10d61a1 for #544) * Support the gel:// dsn protocol (by @msullivan in 84c533c for #546) * Add a way to export SQLAlchemy models from Gel (EdgeDB). (by @vpetrovykh in 645fce0 for #536) * Implement gel.Record type (by @1st1 in ff3aad2 for #560) * Add ORM model generators for Django, SQLAlchemy, sqlmodel. (by @vpetrovykh in ad37a6b) * Add support for REPEATABLE READ isolation (requires server support) (by @elprans in 8f40d0e for #565) * Retry calls to `execute` as well as to `query` (by @msullivan in e263f2b for #577) * Add support for running (and installing) the main CLI (by @elprans in 023697a for #572) * Rename AI to RAGClient and add compat names (by @fantix in e5aae27 for #578)
Merged
msullivan
added a commit
that referenced
this pull request
Feb 23, 2025
EdgeDB has been renamed to Gel, and so has this python package. Changes ======= * Rename the package to gel! The package still provides an ``edgedb`` module in addition to ``gel``, but ``gel`` is now preferred. (by @msullivan in 83349d4 for #566) * Allow cloud instance names to contain '-' and '_' in the org part to support vercel instances (by @msullivan in 5b5be68 for #1084) * Support specifying SNI tls_server_name (by @msullivan in 6b28b98 for #1088) * Support GEL_ env vars and gel.toml (by @msullivan in d0b3961 for #532) * Add support for protocol 3.0 (by @elprans in 2e6a877 for #534) * Add support for newly exposed Postgres types (by @elprans in 48a67c1) * Kill pre-1.0 forever deprecated API / dead code. (by @1st1 in 8669e78) * Rename main module from edgedb to gel (by @msullivan in 10d61a1 for #544) * Support the gel:// dsn protocol (by @msullivan in 84c533c for #546) * Add a way to export SQLAlchemy models from Gel (EdgeDB). (by @vpetrovykh in 645fce0 for #536) * Implement gel.Record type (by @1st1 in ff3aad2 for #560) * Add ORM model generators for Django, SQLAlchemy, sqlmodel. (by @vpetrovykh in ad37a6b) * Add support for REPEATABLE READ isolation (requires server support) (by @elprans in 8f40d0e for #565) * Retry calls to `execute` as well as to `query` (by @msullivan in e263f2b for #577) * Add support for running (and installing) the main CLI (by @elprans in 023697a for #572) * Rename AI to RAGClient and add compat names (by @fantix in e5aae27 for #578)
msullivan
added a commit
that referenced
this pull request
Feb 23, 2025
EdgeDB has been renamed to Gel, and so has this python package. Changes ======= * Rename the package to gel! The package still provides an ``edgedb`` module in addition to ``gel``, but ``gel`` is now preferred. (by @msullivan in 83349d4 for #566) * Allow cloud instance names to contain '-' and '_' in the org part to support vercel instances (by @msullivan in 5b5be68 for #1084) * Support specifying SNI tls_server_name (by @msullivan in 6b28b98 for #1088) * Support GEL_ env vars and gel.toml (by @msullivan in d0b3961 for #532) * Add support for protocol 3.0 (by @elprans in 2e6a877 for #534) * Add support for newly exposed Postgres types (by @elprans in 48a67c1) * Kill pre-1.0 forever deprecated API / dead code. (by @1st1 in 8669e78) * Rename main module from edgedb to gel (by @msullivan in 10d61a1 for #544) * Support the gel:// dsn protocol (by @msullivan in 84c533c for #546) * Add a way to export SQLAlchemy models from Gel (EdgeDB). (by @vpetrovykh in 645fce0 for #536) * Implement gel.Record type (by @1st1 in ff3aad2 for #560) * Add ORM model generators for Django, SQLAlchemy, sqlmodel. (by @vpetrovykh in ad37a6b) * Add support for REPEATABLE READ isolation (requires server support) (by @elprans in 8f40d0e for #565) * Retry calls to `execute` as well as to `query` (by @msullivan in e263f2b for #577) * Add support for running (and installing) the main CLI (by @elprans in 023697a for #572) * Rename AI to RAGClient and add compat names (by @fantix in e5aae27 for #578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests coming...