Adds a patch to ATLAS for grep 3.8+ #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! As I mentioned in the other PR, I'm going to hold off merging this until I decide whether to stick with ATLAS for the time being (for consistency), or switch to OpenBLAS or Blis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Moved this to a new pull request due to #15
When testing newer distros (Arch and Fedora), I encountered an issue with ATLAS that would cause the configuration step to fail. This was due to grep 3.8 and newer throwing a warning into the output saying 'fgrep: warning: fgrep is obsolescent; using grep -F.' This, in turn, would cause ATLAS to fail to find the information it is looking for and fail to configure properly. I added patch-atlas-src.yml, which fixes this issue on affected systems.