Skip to content

Update Default PHP version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

Update Default PHP version #6

merged 1 commit into from
Jul 24, 2020

Conversation

shkkmo
Copy link
Contributor

@shkkmo shkkmo commented Jan 20, 2020

This change lets this role play nice with the default variable introduced to ansible-role-php introduced in this commit: geerlingguy/ansible-role-php@8093947

@shkkmo
Update Default PHP version
187ff92 
This change lets this role play nice with the default variable introduced to ansible-role-php introduced in this commit: geerlingguy/ansible-role-php@8093947
@stale
Copy link

stale bot commented Apr 19, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Apr 19, 2020
@shkkmo
Copy link
Contributor Author

shkkmo commented Apr 20, 2020

this is still awaiting a merge, should be pretty simple and doesn't need to be marked stale.

@stale
Copy link

stale bot commented Apr 20, 2020

This issue is no longer marked for closure.

@stale stale bot removed the stale label Apr 20, 2020
@stale
Copy link

stale bot commented Jul 19, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jul 19, 2020
@shkkmo
Copy link
Contributor Author

shkkmo commented Jul 19, 2020

Just a one line fix I still think this is easily mergeable.

@stale
Copy link

stale bot commented Jul 19, 2020

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jul 19, 2020
@geerlingguy
Copy link
Owner

Yeah this does need fixing!

@geerlingguy geerlingguy merged commit db4c28c into geerlingguy:master Jul 24, 2020
@geerlingguy
Copy link
Owner

Thanks!

geerlingguy added a commit that referenced this pull request Jul 24, 2020
@geerlingguy
PR #6 follow-up: Better version compatibility and testing.
86fef37
geerlingguy added a commit that referenced this pull request Jul 24, 2020
@geerlingguy
PR #6: Test all modern Debian-based OSes for better version compatibi…
4fc965c 
…lity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shkkmo @geerlingguy