Clearing tokens properly #96
Merged
+130
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
geelen
force-pushed
the
clear-tokens
branch
2 times, most recently
from
2246c51 to
14592ca
Compare
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the changes in modelcontextprotocol/typescript-sdk#570
Now, when a MCP server returns a
invalid_clientorinvalid_grantresponse, the corresponding local credentials are wiped and things retry. I have testedhttps://pkg.pr.new/mcp-remote@96and can confirm that several of the failure cases are no longer dead ends. It now just detects the stale data, clears it, and retries.This should mean that
rm -rf ~/.mcp-authis needed a lot less often, and in fact, should allow us to preserve auth betweenmcp-remotereleases (currently every new version saves auth into a new blank subdirectory).This PR is in draft while the upstream PR is in flight, but as soon as that's merged this can be released.