fix: koa tests - sanitizeHeaders

Signed-off-by: seven <zilisheng1996@gmail.com>

Author: Blankll

src/context.ts

@@ -10,16 +10,30 @@ import { debug } from './common';
 //   return event.requestContext.identity.sourceIp;
 // };
 
+const requestBody = (event: Event) => {
+  if (event.body === undefined || event.body === null) {
+    return undefined;
+  }
+  const type = typeof event.body;
+
+  if (Buffer.isBuffer(event.body)) {
+    return event.body;
+  } else if (type === 'string') {
+    return Buffer.from(event.body as string, event.isBase64Encoded ? 'base64' : 'utf8');
+  } else if (type === 'object') {
+    return Buffer.from(JSON.stringify(event.body));
+  }
+
+  throw new Error(`Unexpected event.body type: ${typeof event.body}`);
+};
+
 export const constructFrameworkContext = (event: Event, context: Context) => {
   debug(`constructFrameworkContext: ${JSON.stringify({ event, context })}`);
   const request = new ServerlessRequest({
     method: event.httpMethod,
     headers: event.headers,
     path: event.path,
-    body:
-      event.body !== undefined && event.body !== null
-        ? Buffer.from(event.body, event.isBase64Encoded ? 'base64' : 'utf8')
-        : undefined,
+    body: requestBody(event),
     remoteAddress: '',
     url: url.format({
       pathname: event.path,

src/serverlessResponse.ts

@@ -1,8 +1,7 @@
 import { IncomingHttpHeaders, ServerResponse } from 'http';
-import { IncomingMessage } from 'node:http';
-import ServerlessRequest from './serverlessRequest';
 import { Socket } from 'node:net';
 import { debug } from './common';
+import ServerlessRequest from './serverlessRequest';
 
 const headerEnd = '\r\n\r\n';
 
@@ -37,12 +36,8 @@ export default class ServerlessResponse extends ServerResponse {
   [BODY]: Buffer[];
   [HEADERS]: IncomingHttpHeaders;
 
-  static from(res: IncomingMessage): ServerlessResponse {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error
+  static from(res: ServerlessRequest): ServerlessResponse {
     const response = new ServerlessResponse(res);
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-expect-error
     const { statusCode = 0, headers, body } = res;
     response.statusCode = statusCode;
     response[HEADERS] = headers;

src/transport.ts

@@ -1,7 +1,11 @@
 import { Writable } from 'stream';
+import { IncomingHttpHeaders } from 'http';
 import ServerlessRequest from './serverlessRequest';
 import ServerlessResponse from './serverlessResponse';
 
+type MultiValueHeaders = {
+  [key: string]: string[];
+};
 export const waitForStreamComplete = (stream: Writable): Promise<Writable> => {
   if (stream.writableFinished || stream.writableEnded) {
     return Promise.resolve(stream);
@@ -34,17 +38,58 @@ export const waitForStreamComplete = (stream: Writable): Promise<Writable> => {
   });
 };
 
+const sanitizeHeaders = (headers: IncomingHttpHeaders) => {
+  return Object.keys(headers).reduce(
+    (memo, key) => {
+      const value = headers[key];
+
+      if (Array.isArray(value)) {
+        memo.multiValueHeaders[key] = value;
+        if (key.toLowerCase() !== 'set-cookie') {
+          memo.headers[key] = value.join(', ');
+        }
+      } else {
+        memo.headers[key] = value == null ? '' : value.toString();
+      }
+
+      return memo;
+    },
+    {
+      headers: {} as IncomingHttpHeaders,
+      multiValueHeaders: {} as MultiValueHeaders,
+    },
+  );
+};
+
 export const buildResponse = ({
   request,
   response,
 }: {
   request: ServerlessRequest;
   response: ServerlessResponse;
 }) => {
+  const { headers, multiValueHeaders } = sanitizeHeaders(ServerlessResponse.headers(response));
+
+  let body = ServerlessResponse.body(response).toString(
+    request.isBase64Encoded ? 'base64' : 'utf8',
+  );
+  if (headers['transfer-encoding'] === 'chunked' || response.chunkedEncoding) {
+    const raw = ServerlessResponse.body(response).toString().split('\r\n');
+    const parsed = [];
+    for (let i = 0; i < raw.length; i += 2) {
+      const size = parseInt(raw[i], 16);
+      const value = raw[i + 1];
+      if (value) {
+        parsed.push(value.substring(0, size));
+      }
+    }
+    body = parsed.join('');
+  }
   return {
     statusCode: response.statusCode,
-    body: ServerlessResponse.body(response).toString(request.isBase64Encoded ? 'base64' : 'utf8'),
-    headers: response.headers,
+    body,
+    headers,
+    multiValueHeaders,
     isBase64Encoded: request.isBase64Encoded,
   };
 };

tests/index-koa.test.ts

@@ -55,6 +55,7 @@ describe('koa', () => {
       ctx.status = 200;
       ctx.body = ctx.request.body.hello;
     });
+    app.use(router.routes());
 
     const response = await serverlessAdapter(app)(
       {
@@ -76,6 +77,7 @@ describe('koa', () => {
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       ctx.body = ctx.request.body.hello;
     });
+    app.use(router.routes());
 
     const response = await serverlessAdapter(app)(
       {
@@ -89,7 +91,7 @@ describe('koa', () => {
       defaultContext,
     );
 
-    expect(response.statusCode).toEqual(200);
+    expect(response.statusCode).toEqual(204);
     expect(response.body).toBeDefined();
   });
 
@@ -98,12 +100,12 @@ describe('koa', () => {
       ctx.status = 200;
       ctx.body = ctx.request.query.foo;
     });
+    app.use(router.routes());
 
     const response = await serverlessAdapter(app)(
       {
         ...defaultEvent,
         httpMethod: 'GET',
-        path: '/',
         queryParameters: {
           foo: 'bar',
         },