make test fails for t/unittest

[p-alik]

this is also mentioned in

• Exception/Terminate warnings when building on Debian 9 / gcc 6.3 #134 (comment)
• make test: Assertion 'Application::SUCCESS' != 'true_app.run(args)'  #181
• Failing tests, gearman 1.1.18 #151

Configuration summary for gearmand version 1.1.18-45-g3c35e0d7

   * Installation prefix:       /usr/local
   * System type:               pc-linux-gnu
   * Host CPU:                  x86_64
   * C Compiler:                cc cc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
   * C Flags:                   -g -O2  -fstack-check -Wpragmas -Wunknown-pragmas -Wall -Wextra -Wunsuffixed-float-constants -Wjump-misses-init -Wno-attributes -Waddress -Wvarargs -Warray-bounds -Wbad-function-cast -Wchar-subscripts -Wcomment -Wfloat-equal -Wformat-security -Wformat=2 -Wformat-y2k -Wlogical-op -Wmaybe-uninitialized -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnormalized=id -Woverride-init -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wswitch-enum -Wtrampolines -Wundef -funsafe-loop-optimizations -Wclobbered -Wunused -Wunused-result -Wunused-variable -Wunused-parameter -Wunused-local-typedefs -Wwrite-strings -fwrapv -pipe -fPIE -pie -Wsizeof-pointer-memaccess -Wpacked -Werror
   * C++ Compiler:              c++ c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
   * C++ Flags:                  -g -O2 -fstack-check -Wpragmas -Wunknown-pragmas -Wall -Wextra -Wno-attributes -Wvarargs -Waddress -Warray-bounds -Wchar-subscripts -Wcomment -Wctor-dtor-privacy -Wfloat-equal -Wformat=2 -Wformat-y2k -Wmaybe-uninitialized -Wmissing-field-initializers -Wlogical-op -Wnon-virtual-dtor -Wnormalized=id -Woverloaded-virtual -Wpointer-arith -Wredundant-decls -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wswitch-enum -Wtrampolines -Wundef -funsafe-loop-optimizations -Wc++11-compat -Wclobbered -Wunused -Wunused-result -Wunused-variable -Wunused-parameter -Wunused-local-typedefs -Wwrite-strings -Wformat-security -fwrapv -pipe -fPIE -pie -Wsizeof-pointer-memaccess -Wpacked -Werror -std=c++0x
   * CPP Flags:                  -fvisibility=hidden
   * LIBS:                      
   * LDFLAGS Flags:              -Werror -rdynamic
   * Assertions enabled:        yes
   * Debug enabled:             no
   * Warnings as failure:       yes
   * Building with hiredis      yes
   * Building with libsqlite3   no
   * Building with libdrizzle   yes
   * Building with libmemcached not found
   * Building with libpq        no
   * Building with tokyocabinet no
   * Building with libmysql     no
   * SSL enabled:               no
   * wolfssl found:             no
   * openssl found:             yes
   * make -j:                   2
   * VCS checkout:              yes
   * sphinx-build:              /usr/bin/sphinx-build

$ ./t/unittest 
unittest.environment.getenv()					0:000000408 [ ok ]

libtest/unittest.cc:73: in LIBTOOL_COMMAND_test() pid(3300) Assertion 'getenv("LIBTOOL_COMMAND")'
unittest.environment.LIBTOOL_COMMAND					[ failed ]

libtest/unittest.cc:79: in VALGRIND_COMMAND_test() pid(3300) Assertion 'getenv("VALGRIND_COMMAND")'
unittest.environment.VALGRIND_COMMAND					[ failed ]

libtest/unittest.cc:98: in HELGRIND_COMMAND_test() pid(3300) Assertion 'getenv("HELGRIND_COMMAND")'
unittest.environment.HELGRIND_COMMAND					[ failed ]

libtest/unittest.cc:104: in GDB_COMMAND_test() pid(3300) Assertion 'getenv("GDB_COMMAND")'
unittest.environment.GDB_COMMAND					[ failed ]
unittest.environment.valgrind_is_caller()					[ skipped ]
unittest.return values.TEST_SUCCESS					0:000000374 [ ok ]
unittest.return values.TEST_FAILURE					0:000013060 [ ok ]
unittest.return values.TEST_SUCCESS == 0					[ skipped ]
unittest.return values.SUCCESS					0:000007484 [ ok ]
unittest.return values.libtest::__skipped					0:000005451 [ ok ]
unittest.return values.SKIP_IF					0:000003634 [ ok ]
unittest.return values.SKIP_UNLESS					0:000003379 [ ok ]
unittest.return values.FAIL					0:000004408 [ ok ]
unittest.return values.ASSERT_FALSE_					0:000005963 [ ok ]
unittest.return values.ASSERT_FALSE					0:000003849 [ ok ]
unittest.return values.ASSERT_NEQ					0:000000173 [ ok ]
unittest.return values.ASSERT_NEQ FAIL					0:000004235 [ ok ]
unittest.return values.ASSERT_NOT_NULL FAIL					0:000005471 [ ok ]
unittest.test_skip().true, true					0:000000455 [ ok ]
unittest.test_skip().true, false					0:000000408 [ ok ]
unittest.local.test_is_local()					0:000000539 [ ok ]
unittest.local.test_is_local(NOT)					[ skipped ]
unittest.directories.var exists					0:000004552 [ ok ]
unittest.directories.var/tmp exists					0:000003184 [ ok ]
unittest.directories.var/run exists					0:000003244 [ ok ]
unittest.directories.var/log exists					0:000004399 [ ok ]
unittest.directories.var/drizzle exists					0:000003134 [ ok ]
unittest.directories.var/tmp					0:000028432 [ ok ]
unittest.directories.var/run					0:000021628 [ ok ]
unittest.directories.var/log					0:000021331 [ ok ]
unittest.directories.var/drizzle					0:000016644 [ ok ]
unittest.directories.var/tmp rm					0:000018504 [ ok ]
unittest.directories.var/run rm					0:000011884 [ ok ]
unittest.directories.var/log rm					0:000013821 [ ok ]
unittest.directories.var/drizzle rm					0:000010856 [ ok ]
unittest.comparison._compare(test_return_t)					0:000000162 [ ok ]
unittest.gearmand.gearmand startup-shutdown					1:003582565 [ ok ]
unittest.gearmand._compare(gearman_return_t)					0:000001816 [ ok ]
unittest.gearmand.server_startup(fail)					0:000243798 [ ok ]
unittest.cmdline.echo fubar					0:001272403 [ ok ]
unittest.cmdline.core-count					0:042304724 [ ok ]
unittest.cmdline.wait --quiet					0:039466750 [ ok ]
unittest.cmdline.wait --quiet --help					0:042103888 [ ok ]
unittest.cmdline.wait --quiet --version					0:041089644 [ ok ]
unittest.cmdline.wait --quiet /etc/services					0:044186471 [ ok ]
unittest.cmdline.wait /etc/services					0:042780934 [ ok ]
unittest.cmdline.wait /etc/services					[ skipped ]
unittest.cmdline.gdb wait /etc/services					[ skipped ]
unittest.cmdline.gdb abort					[ skipped ]
unittest.application.vchar_t					0:000001205 [ ok ]
unittest.application.vchar_t make() append()					0:000002499 [ ok ]
unittest.application.vchar_t compare()					0:000000776 [ ok ]
unittest.application.true					[ skipped ]
unittest.application.gbd true --fubar					[ skipped ]
unittest.application.gbd true					[ skipped ]
unittest.application.true --fubar					[ skipped ]

libtest/unittest.cc:663: in application_doesnotexist_BINARY() pid(3300) Assertion 'Application::SUCCESS' != 'true_app.run(args)'
unittest.application.doesnotexist --fubar					[ failed ]
unittest.application.echo fubar					0:000000239 [ ok ]
unittest.application.echo fubar (as option)					0:000000237 [ ok ]
unittest.get_free_port().get_free_port()					0:000059777 [ ok ]
unittest.get_free_port().default_port()					0:000000486 [ ok ]
unittest.fatal.libtest::fatal					0:000021536 [ ok ]
unittest.fatal.fatal_message()					0:000013642 [ ok ]
unittest.number_of_cpus().libtest::number_of_cpus()					0:000000209 [ ok ]
unittest.create_tmpfile().libtest::create_tmpfile()					0:000710197 [ ok ]
unittest.dns.libtest::lookup(true)					0:000864510 [ ok ]
unittest.dns.libtest::lookup(false)					0:000400786 [ ok ]
unittest.dns.libtest::check_dns()					0:000628781 [ ok ]
unittest.libtest::Timer.libtest::Timer					0:000000622 [ ok ]

[illuusio]

Noted this too when hunting why it jams

[esabol]

This only happens with gcc 7.3?

[p-alik]

This only happens with gcc 7.3?

#134 (comment) points to gcc 6.3

[esabol]

So why doesn't it happen in the Travis CI builds? Or does it on some occasions?

[p-alik]

So why doesn't it happen in the Travis CI builds? Or does it on some occasions?

Just a guess, because Travis CI is based on Ubuntu 16.04.