Gh-3238: target delete accumulo (#3249)

* Gh-3237 Implement DeleteElements for Map Store

* remove unused param

* spotless

* wip

* finish

* checkstyle

* codecov and sonarcloud

* improve codecov and sonarcloud

* reduce test duplication and add to federated store

* checkstyle

* remove unused properties and improve check

* Gh-3238 Implement DeleteElements for Accumulo

* add accumulo test to federated store

* remove commented test

* address comments

* address comments

* checkstyle

* checkstyle

* headers

* code cov

* remove public

* remove AccumuloClient

* code cov

* checkystle

* add test

---------

Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>

Author: p29876

store-implementation/accumulo-store/pom.xml

@@ -179,6 +179,12 @@
             <artifactId>junit-platform-suite</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-inline</artifactId>
+            <version>${mockito.version}</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

store-implementation/accumulo-store/src/main/java/uk/gov/gchq/gaffer/accumulostore/AccumuloStore.java

@@ -18,6 +18,7 @@
 
 import com.google.common.collect.Sets;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import org.apache.accumulo.core.client.AccumuloSecurityException;
 import org.apache.accumulo.core.client.BatchWriter;
 import org.apache.accumulo.core.client.ClientConfiguration;
@@ -42,6 +43,7 @@
 import uk.gov.gchq.gaffer.accumulostore.key.exception.AccumuloElementConversionException;
 import uk.gov.gchq.gaffer.accumulostore.key.exception.IteratorSettingException;
 import uk.gov.gchq.gaffer.accumulostore.operation.handler.AddElementsHandler;
+import uk.gov.gchq.gaffer.accumulostore.operation.handler.DeleteElementsHandler;
 import uk.gov.gchq.gaffer.accumulostore.operation.handler.GenerateSplitPointsFromSampleHandler;
 import uk.gov.gchq.gaffer.accumulostore.operation.handler.GetAdjacentIdsHandler;
 import uk.gov.gchq.gaffer.accumulostore.operation.handler.GetAllElementsHandler;
@@ -105,6 +107,7 @@
 import uk.gov.gchq.koryphe.iterable.ChainedIterable;
 
 import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
@@ -140,6 +143,7 @@
  */
 public class AccumuloStore extends Store {
 
+    private static final String MUTATION_ERROR = "Failed to create an accumulo key mutation";
     public static final Set<StoreTrait> TRAITS = Collections.unmodifiableSet(Sets.newHashSet(
             ORDERED,
             VISIBILITY,
@@ -415,8 +419,7 @@ protected OutputOperationHandler<GetTraits, Set<StoreTrait>> getGetTraitsHandler
 
     @Override
     protected OperationHandler<? extends DeleteElements> getDeleteElementsHandler() {
-        // TODO: implement accumulo delete handler logic
-        return null;
+        return new DeleteElementsHandler();
     }
 
     /**
@@ -462,7 +465,7 @@ protected void insertGraphElements(final Iterable<? extends Element> elements) t
                 try {
                     writer.addMutation(m);
                 } catch (final MutationsRejectedException e) {
-                    LOGGER.error("Failed to create an accumulo key mutation");
+                    LOGGER.error(MUTATION_ERROR);
                     continue;
                 }
                 // If the GraphElement is a Vertex then there will only be 1 key,
@@ -478,7 +481,7 @@ protected void insertGraphElements(final Iterable<? extends Element> elements) t
                     try {
                         writer.addMutation(m2);
                     } catch (final MutationsRejectedException e) {
-                        LOGGER.error("Failed to create an accumulo key mutation");
+                        LOGGER.error(MUTATION_ERROR);
                     }
                 }
             }
@@ -492,6 +495,53 @@ protected void insertGraphElements(final Iterable<? extends Element> elements) t
         }
     }
 
+    /**
+     * Method to delete {@link Element}s from Accumulo.
+     *
+     * @param elements The elements to be deleted.
+     * @throws StoreException If there is a failure to delete elements.
+     */
+    public void deleteElements(final Iterable<? extends Element> elements) throws StoreException {
+        deleteGraphElements(elements);
+    }
+
+    protected void deleteGraphElements(final Iterable<? extends Element> elements) throws StoreException {
+        // Create BatchWriter
+        // Loop through elements, convert to mutations, and add to BatchWriter
+        // The BatchWriter takes care of batching them up, sending them without
+        // too high a latency, etc.
+        if (elements == null) {
+            throw new GafferRuntimeException("Could not find any elements to delete from graph.", Status.BAD_REQUEST);
+        }
+
+        try (BatchWriter writer = TableUtils.createBatchWriter(this)) {
+            for (final Element element : elements) {
+                final Pair<Key, Key> keys;
+                try {
+                    keys = getKeyPackage().getKeyConverter().getKeysFromElement(element);
+                } catch (final AccumuloElementConversionException e) {
+                    LOGGER.error(FAILED_TO_CREATE_AN_ACCUMULO_FROM_ELEMENT_OF_TYPE_WHEN_TRYING_TO_INSERT_ELEMENTS, "key", element.getGroup());
+                    continue;
+                }
+
+                for (final Key key : Arrays.asList(keys.getFirst(), keys.getSecond())) {
+                    if (nonNull(key)) {
+                        final Mutation m = new Mutation(key.getRow());
+                        m.putDelete(key.getColumnFamily(), key.getColumnQualifier(), key.getTimestamp());
+
+                        try {
+                            writer.addMutation(m);
+                        } catch (final MutationsRejectedException e) {
+                            LOGGER.error(MUTATION_ERROR);
+                        }
+                    }
+                }
+            }
+        } catch (final MutationsRejectedException e) {
+            LOGGER.warn("Accumulo batch writer failed to close", e);
+        }
+    }
+
     /**
      * Gets the {@link uk.gov.gchq.gaffer.accumulostore.key.AccumuloKeyPackage} in use by
      * this AccumuloStore.

store-implementation/accumulo-store/src/main/java/uk/gov/gchq/gaffer/accumulostore/operation/handler/DeleteElementsHandler.java

@@ -0,0 +1,54 @@
+/*
+ * Copyright 2024 Crown Copyright
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package uk.gov.gchq.gaffer.accumulostore.operation.handler;
+
+import uk.gov.gchq.gaffer.accumulostore.AccumuloStore;
+import uk.gov.gchq.gaffer.data.element.Element;
+import uk.gov.gchq.gaffer.operation.OperationException;
+import uk.gov.gchq.gaffer.operation.impl.delete.DeleteElements;
+import uk.gov.gchq.gaffer.store.Context;
+import uk.gov.gchq.gaffer.store.Store;
+import uk.gov.gchq.gaffer.store.StoreException;
+import uk.gov.gchq.gaffer.store.ValidatedElements;
+import uk.gov.gchq.gaffer.store.operation.handler.OperationHandler;
+
+public class DeleteElementsHandler implements OperationHandler<DeleteElements> {
+
+    @Override
+    public Object doOperation(final DeleteElements operation,
+            final Context context, final Store store)
+            throws OperationException {
+        deleteElements(operation, (AccumuloStore) store);
+        return null;
+    }
+
+    private void deleteElements(final DeleteElements operation, final AccumuloStore store)
+            throws OperationException {
+        try {
+            final Iterable<? extends Element> validatedElements;
+            if (operation.isValidate()) {
+                validatedElements = new ValidatedElements(operation.getInput(), store.getSchema(),
+                        operation.isSkipInvalidElements());
+            } else {
+                validatedElements = operation.getInput();
+            }
+            store.deleteElements(validatedElements);
+        } catch (final StoreException e) {
+            throw new OperationException("Failed to delete elements", e);
+        }
+    }
+}