Fix: Reverse highlights unwind incorrectly #2022
Open
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it seems that a recipe calculates its reversed highlights 'forwards' through each operation which creates highlights that don't make sense. While a single recipe's reverseHighlight might work, chaining two operations creates nonsensical reverse highlights. Instead, flip the highlight operation list backwards to 'unwind' the selections when calculating reversed highlights.
Current behavior - in the reverse, ToHexdump applies reverse highlights to map the hexdump's bytes to the input bytes, and FromHex maps from raw input bytes selection to 2 characters/byte selections. When chained, reverse highlighting ends up with a wrong offset while forward highlighting works fine.

Resolved behavior - by flipping the highlights array for the reverse direction, we effectively unwind the highlighting when sequencing multiple operations together
