Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Type Checking Throughout Project #84

Open
gbroques opened this issue May 17, 2020 · 0 comments
Open

Revisit Type Checking Throughout Project #84

gbroques opened this issue May 17, 2020 · 0 comments
Labels

Comments

@gbroques
Copy link
Owner

gbroques commented May 17, 2020

We do a lot of type checking throughout the project as there's a lot of code that needs to know this object is an axis, frame, extruder, heated bed, etc.

This seems like a cross-cutting concern, and we should probably have some type_check utility module or documented pattern for solving this problem.

Research

Look for usages of .Proxy.Type in code.

image

Summarizing what code needs to know about the "type" of objects in the document:

  1. Module for getting objects from the user's selection
    • For preventing passing invalid objects like plain cubes to attachment functions.
  2. Attachment functions
    • For validating objects passed to attachment function are as advertised.
  3. and the function for building the cut list
    • For querying a document for the objects in it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant