Improve CSS query with getter and setter, keep order of css entries #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good point. But your patch break all the tests |
|
Does the module target python 2.6, because OrderedDict is >2.7 only. I think the rst tests are failing because of the added semi-colon at the end. And the local tests (setup.py test has no tests in it) tests.py all pass. Which means this project has multiple testing frameworks in place. How are these documentation tests run locally? |
|
It use tox. Like most projects. Just pip install tox and run tox. |
cclauss
reviewed
Jan 2, 2023
| @@ -12,6 +12,7 @@ | |||
| import types | |||
| import sys | |||
|
|
|||
| from collections import OrderedDict | |||
There was a problem hiding this comment.
Since Python 3.7: Dictionary order for all dicts is guaranteed to be insertion order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to do some svg work and svg has /a lot/ of embedded css. So I needed to upgrade pyquery to support the full jquery css command. I've made it work just like the js version with regards to how it returns getter values as well as getting lists and setting.
I also managed to reduce the code duplication between setting one item and setting a dictionary.
Tests to cover the function included.