Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feedback] add configuration saving #1

Open
subbota-a opened this issue Sep 22, 2024 · 7 comments
Open

[feedback] add configuration saving #1

subbota-a opened this issue Sep 22, 2024 · 7 comments

Comments

@subbota-a
Copy link

Hi!

Thank you for your amazing tool! It solves all my needs.
But for complete convenience, saving the configurations of the current settings is not enough:

  • Series names mapping
  • The argument name mapping
  • Y axis
  • A type of the charts
  • Checked/unchecked ticks
  • To be short - everything user changed)

I suppose it will be buttons [save to] [load from]

If you think my idea is good, let me know...

@gaujay
Copy link
Owner

gaujay commented Sep 22, 2024

Hi!

Thanks for your feedback. It's nice to know JOMT is useful to people.

To clarify, in what scenario would you like to see settings saved?
It seems that the last version of the tool already store most of these parameters
(and try to re-apply them on compatible charts when possible).

@subbota-a
Copy link
Author

Hi!

My scenario:

  1. Develop a benchmark
  2. Run the benchmark
  3. Run JOMT
  4. Open the json
  5. Choose the Chart Type (Bar e.g.)
  6. Choose Y column (items/s e.g.)
  7. Uncheck 'Auto-reload' (because when I restart benchmark JOMT tries to reload json while it is invalid)
  8. Press Plot button
  9. Again uncheck 'auto-reload'
  10. Choose theme
  11. Increase legend font size
  12. Edit series names
  13. etc, etc
  14. Press Snapshot to save the results
  15. Then I refactor the code to improve performance or do some experiments. It can take hour, day or week, so, I close JOMT
  16. Return to the 3 step and have to repeat the configuration

I would like to save the current config to some file (perhaps near to the result file) and reload it just after I open the report.

@gaujay
Copy link
Owner

gaujay commented Sep 22, 2024

Hello,

For what I can see, except for steps 5 and 6, all the others configs should be restored on re-opening the same benchmark.
Are you up-to-date on the repository? (there was an update about 6 months ago)
Does it work if you re-open JOMT on the same benchmark file? (or is it just an issue with updated results file)

Note: auto-reload will show a warning popup on invalid json, but shouldn't mess with working copy.
However, It seems to show a dialog per failed parsing which could be annoying. I'll add this to my todo list

@subbota-a
Copy link
Author

Sorry, I didn't understand your question.

@gaujay
Copy link
Owner

gaujay commented Sep 22, 2024

Did you build the last JOMT version? (the one with the update to Qt6):
https://github.com/gaujay/jomt/commits/master/

In my scenario:

  1. Open a benchmark file in JOMT
  2. Plot chart
  3. Change theme/Series name
  4. Close and re-open JOMT
  5. Open same benchmark file, plot same chart type
  6. Changed theme/Series name should be re-loaded from config file

You can check the content of the config files (one per chart type) in folder 'jomtSettings' located near the JOMT binary.
Hope this helps!

@subbota-a
Copy link
Author

Did you build the last JOMT version? (the one with the update to Qt6):

yes, I download and build your last version just today

You can check the content of the config files (one per chart type) in folder 'jomtSettings' located near the JOMT binary.

jomtSettings is empty in my case

But nevertheless, I suppose, that the config file should be per benchmark file but not per chart type...

@gaujay
Copy link
Owner

gaujay commented Sep 22, 2024

A config file per benchmark could be an interesting addition.
But in your case, fixing the missing config files per chart type would already address most of your needs.

Check your read/write permissions or put a breakpoint into JOMT save/load functions to see what's the problem here.
If there is a bug in the code, please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants