fix: linting check on azure/appveyor #9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
force-pushed
the
fix-ignore-patterns
branch
from
4d79258 to
cb3e7bc
Compare
DSchau
approved these changes
Nov 7, 2018
| packages/**/*.js | ||
| !packages/gatsby/cache-dir/**/*.js | ||
| !packages/*/src/**/*.js | ||
| packages/gatsby/cache-dir/commonjs/**/*.js |
There was a problem hiding this comment.
ugh, this sucks :( necessarily evil I suppose.
| @@ -1,3 +1,4 @@ | |||
| **/*.js.snap text eol=lf | |||
| **/__testfixtures__/** text eol=lf | |||
| **/__tests__/fixtures/** text eol=lf | |||
| **/*.md text eol=lf | |||
There was a problem hiding this comment.
This looks good; was there a reason we didn't just add this for all files?
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
seems like current (bit whacky) patterns don't play nice on windows for some reason, let's try different ones note - there is currently unrelated lint error in `www` so linting should fail - but it should have 1 error instead of thousands of errors on azure/appveyor - with this gatsbyjs#9780 should be clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like current (bit whacky) patterns don't play nice on windows for some reason, let's try different ones
note - there is currently unrelated lint error in
wwwso linting should fail - but it should have 1 error instead of thousands of errors on azure/appveyor - with this #9780 should be clear