Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format JS Files #8623

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Format JS Files #8623

merged 1 commit into from
Nov 6, 2018

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Sep 28, 2018

After we merge #8427

@lipis lipis requested review from a team as code owners September 28, 2018 17:24
@lipis lipis requested a review from a team October 4, 2018 10:40
DSchau
DSchau suggested changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the linter is failing pretty hard. You able to take a look at that?

https://circleci.com/gh/gatsbyjs/gatsby/8316?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@lipis
Copy link
Contributor Author

lipis commented Oct 5, 2018

This is just a test and the current state.. once we agree on #8427 that's next in line to make it pass all the linters.

@lipis lipis force-pushed the js branch 2 times, most recently from b08a89f to 1a275f8 Compare November 6, 2018 18:38
@lipis lipis mentioned this pull request Nov 6, 2018
Merged
3 tasks
@lipis lipis requested a review from DSchau November 6, 2018 19:33
@pieh pieh merged commit e1f1a98 into gatsbyjs:master Nov 6, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@lipis @gpetrioli
chore: Format JS Files (gatsbyjs#8623)
a3cb916 
After we merge gatsbyjs#8427
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@lipis @pieh
chore: Format JS Files (gatsbyjs#8623)
90d9b42 
After we merge gatsbyjs#8427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonbux shannonbux shannonbux approved these changes

@pieh pieh pieh approved these changes

@DSchau DSchau Awaiting requested review from DSchau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lipis @pieh @DSchau @shannonbux