Skip to content

fix(gatsby): don't serve codeframes for files outside of compilation #38059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

fix(gatsby): don't serve codeframes for files outside of compilation #38059

merged 2 commits into from
May 5, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented May 5, 2023 •
edited
Loading

Description

This adds additional checks before serving codeframes that are used in error overlay to avoid serving unintended content

Tests

Added test case ensuring we don't serve source files not related/used in current project

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2023
@pieh pieh added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 5, 2023
@pieh pieh marked this pull request as ready for review May 5, 2023 12:03
@pieh pieh merged commit ed5855e into master May 5, 2023
@pieh pieh deleted the fix/serving-not-from-compilation branch May 5, 2023 12:03
@gatsbybot gatsbybot mentioned this pull request May 5, 2023
Merged
pieh added a commit that referenced this pull request May 5, 2023
@pieh
fix(gatsby): don't serve codeframes for files outside of compilation (#…
d825630 
…38059)

* test: add test case for overlay handlers

* fix: don't serve codeframes for files outside of compilation

(cherry picked from commit ed5855e)
@gatsbybot gatsbybot mentioned this pull request May 5, 2023
Merged
pieh added a commit that referenced this pull request May 5, 2023
@pieh
fix(gatsby): don't serve codeframes for files outside of compilation (#…
c97bd6c 
…38059)

* test: add test case for overlay handlers

* fix: don't serve codeframes for files outside of compilation

(cherry picked from commit ed5855e)
pieh added a commit that referenced this pull request May 5, 2023
@gatsbybot @pieh
fix(gatsby): don't serve codeframes for files outside of compilation (#…
ae5a654 
…38059) (#38062)

* test: add test case for overlay handlers

* fix: don't serve codeframes for files outside of compilation

(cherry picked from commit ed5855e)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh added a commit that referenced this pull request May 5, 2023
@gatsbybot @pieh
fix(gatsby): don't serve codeframes for files outside of compilation (#…
fc22f4b 
…38059) (#38063)

* test: add test case for overlay handlers

* fix: don't serve codeframes for files outside of compilation

(cherry picked from commit ed5855e)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@snyk-bot snyk-bot mentioned this pull request May 16, 2023
Open
@philipedin philipedin mentioned this pull request May 16, 2023
Open
@0xSebin 0xSebin mentioned this pull request May 16, 2023
Open
This was referenced May 16, 2023
Open
Open
This was referenced May 16, 2023
Open
Open
@0xSebin 0xSebin mentioned this pull request May 16, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 16, 2023
Open
This was referenced May 16, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 16, 2023
Open
@0xSebin 0xSebin mentioned this pull request May 16, 2023
Open
@monizb monizb mentioned this pull request May 16, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 17, 2023
Open
This was referenced Sep 29, 2023
Open
Open
@Rutam21 Rutam21 mentioned this pull request Oct 14, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 27, 2023
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 1, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 15, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 15, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Jan 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 6, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Jan 10, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Jan 24, 2024
Open
This was referenced Jan 24, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Feb 23, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Feb 23, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Mar 22, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 18, 2024
Open
Open
Open
This was referenced May 7, 2024
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 15, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Oct 9, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LekoArts LekoArts LekoArts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pieh @HMMM116 @LekoArts