fix(gatsby-source-wordpress): Add back nodeType field that was removed in last version #37212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
TylerBarnes
requested review from
DanielSLew,
kathmbeck,
sophiemcgarity and
wardpeet
kathmbeck
approved these changes
Dec 7, 2022
TylerBarnes
added
the
bot: merge on green
pieh
pushed a commit
that referenced
this pull request
Dec 8, 2022
…d in last version (#37212) (#37219) * canary commit * move typedef interfaces definition to __all type filter * add the nodeType field to any type that implements Node * Revert "canary commit" This reverts commit fd7f83d. * update snapshot (cherry picked from commit b7d7b07) Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
pieh
pushed a commit
that referenced
this pull request
Dec 8, 2022
…d in last version (#37212) (#37218) * canary commit * move typedef interfaces definition to __all type filter * add the nodeType field to any type that implements Node * Revert "canary commit" This reverts commit fd7f83d. * update snapshot (cherry picked from commit b7d7b07) Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com>
This was referenced Jan 12, 2023
Open
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37134 I removed the
nodeTypefield instead of adding it to more types (in order to get the schema to build properly). This was a breaking change but since I believed people didn't use this field I thought that was ok (adding the field was a mistake originally). Turns out lots of people use this field so I'm adding it back + adding it to more types than before to get the schema to build properly.Related to #37114