fix(gatsby): stitch slices if just page html was regenerating without any of used slices regenerating #36950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any of used slices regenerating
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: core
LekoArts
approved these changes
Nov 3, 2022
This was referenced Nov 8, 2022
This was referenced Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently mark html for (re)stitching when:
But we were not (re)stitching when just base page was regenerated and none of the slices used by a page did (there might be 0 user slices, there is always at least 1 special gatsby scripts slice).
This result in following empty slice placeholder on outputted html:
This PR just makes sure we mark page for (re)stitching if it was regenerated