Skip to content

Conversation

that1matt
Copy link
Contributor

Description

gatsby-source-graphql throws warning when passing in dataLoaderOptions in gatsby-config.js.

warn Warning: there are unknown plugin options for "gatsby-source-graphql": dataLoaderOptions
Please open an issue at https://ghub.io/gatsby-source-graphql if you believe this option is valid.

Documentation

Grabbed initial types from dataLoaderOptions

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 12, 2022
@that1matt that1matt changed the title [gatsby-source-graphql] add dataLoaderOptions validation to gatsby-source-graphql [gatsby-source-graphql] fix: add dataLoaderOptions validation to gatsby-source-graphql Jul 12, 2022
@imjoshin imjoshin added topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 12, 2022
@that1matt that1matt dismissed a stale review via e8946bd August 11, 2022 19:56
@that1matt that1matt force-pushed the gatsby-source-grapqhl-dataloader-options branch from ad6e924 to e8946bd Compare August 11, 2022 19:56
@that1matt that1matt force-pushed the gatsby-source-grapqhl-dataloader-options branch from e8946bd to 7d99cc6 Compare August 24, 2022 17:48
@that1matt
Copy link
Contributor Author

@j0sh77 is there anything I need to do to help get this merged in?

@imjoshin
Copy link
Contributor

imjoshin commented Aug 24, 2022

@j0sh77 is there anything I need to do to help get this merged in?

Sorry, this slipped through the cracks. Based off of https://github.com/graphql/dataloader#new-dataloaderbatchloadfn--options, this looks good to me. Thank you! 💜

Just gonna wait for the tests and I'll merge once those look good.

@imjoshin imjoshin changed the title [gatsby-source-graphql] fix: add dataLoaderOptions validation to gatsby-source-graphql fix(gatsby-source-graphql): add dataLoaderOptions validation to gatsby-source-graphql Aug 24, 2022
@imjoshin imjoshin merged commit b8c2072 into gatsbyjs:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants