Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-core-utils): add tree-shake (esm) to core-utils #36020

Merged
merged 5 commits into from
Jul 5, 2022
Merged

fix(gatsby-core-utils): add tree-shake (esm) to core-utils #36020

merged 5 commits into from
Jul 5, 2022

Conversation

wardpeet
Copy link
Contributor

Description

Create separate mjs file for core-utils to support tree-shaking in webpack

Related Issues

[ch52460]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 30, 2022
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 30, 2022
LekoArts
LekoArts reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got two typos for the types? Rest LGTM

packages/gatsby-core-utils/package.json Outdated Show resolved Hide resolved
packages/gatsby-core-utils/package.json Outdated Show resolved Hide resolved
wardpeet and others added 2 commits July 1, 2022 11:27
@wardpeet @LekoArts
Apply suggestions from code review
581b847 
Co-authored-by: Lennart <lekoarts@gmail.com>
@wardpeet
fix resolving
8ba0133
@wardpeet wardpeet merged commit 6df573f into master Jul 5, 2022
@wardpeet wardpeet deleted the fix/tree-shake-core-utils branch July 5, 2022 10:46
@angeloashmore angeloashmore mentioned this pull request Aug 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts left review comments

@tyhopp tyhopp tyhopp approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wardpeet @tyhopp @LekoArts