Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-link] Add location object as valid to prop #3407

Merged
merged 6 commits into from
Jan 8, 2018

Conversation

nsimonson
Copy link
Contributor

Adds support for passing a location object to the to prop in gatsby-link. It matches the interface for react-router Link. https://reacttraining.com/react-router/web/api/Link/to-object

Fixes #3309

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jan 4, 2018

Deploy preview ready!

Built with commit 7cda16a

https://deploy-preview-3407--gatsbygram.netlify.com

@ghost ghost assigned KyleAMathews Jan 8, 2018
@ghost ghost added the review label Jan 8, 2018
@KyleAMathews KyleAMathews merged commit d458fe7 into gatsbyjs:master Jan 8, 2018
@ghost ghost removed the review label Jan 8, 2018
@KyleAMathews
Copy link
Contributor

Thanks for the great PR w/ tests!!!

@jlengstorf
Copy link
Contributor

Hiya @nsimonson! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

1 similar comment
@jlengstorf
Copy link
Contributor

Hiya @nsimonson! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants