Skip to content

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 30, 2021

Description

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 30, 2021
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 30, 2021
Comment on lines -92 to +95
export function addSiteMeasurement(event: string, obj): void {
export function addSiteMeasurement(
event: string,
obj: ITelemetryTagsPayload["siteMeasurements"]
): void {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just add type for obj (instead of any)

@pieh pieh marked this pull request as ready for review October 20, 2021 17:07
@pieh pieh merged commit 7d66a23 into master Oct 20, 2021
@pieh pieh deleted the capture-render-mode-type-counts branch October 20, 2021 18:22
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants