fix(gatsby): workaround graphql-compose issue #29822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: GraphQL
sidharthachatterjee
approved these changes
Feb 27, 2021
Contributor
sidharthachatterjee
left a comment
sidharthachatterjee
left a comment
There was a problem hiding this comment.
Nice catch! Thank you @vladar
|
I have a plan for how to fix this problem in graphql-compose but it will take months. Sorry, suppose this workaround may stay with you for months 😉 I found vladar's workaround very elegant and don't see any problems. |
vladar
added a commit
that referenced
this pull request
Feb 28, 2021
* fix(gatsby): workaround graphql-compose issue * freeze after building (cherry picked from commit 7f9bcf1)
vladar
added a commit
that referenced
this pull request
Feb 28, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Apr 15, 2024
This was referenced May 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've noticed that the query running step on v3 is pretty slow. After investigation, the issue was discovered in
graphql-compose: graphql-compose/graphql-compose#319This PR is a workaround for it. But the proper fix should be added in
graphql-composeitself. Once fixed upstream, we can remove this workaround.