Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Use vendored @reach/router #29772

Merged
merged 10 commits into from
Feb 26, 2021
Merged

fix(gatsby): Use vendored @reach/router #29772

merged 10 commits into from
Feb 26, 2021

Conversation

ascorbic
Copy link
Contributor

As @reach/router is unmaintained, and lacks React 17 support, we'll switch to a vendored version

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
@ascorbic ascorbic requested a review from wardpeet February 25, 2021 17:14
@ascorbic ascorbic removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 26, 2021
@ascorbic ascorbic marked this pull request as ready for review February 26, 2021 14:49
wardpeet
wardpeet approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, let's test on @next. Tests will fail if alias doesn't work

wardpeet
wardpeet approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, let's test on @next. Tests will fail if alias doesn't work

@ascorbic ascorbic merged commit 8754e0c into master Feb 26, 2021
@ascorbic ascorbic deleted the chore/vendor-reach-router branch February 26, 2021 17:02
vladar pushed a commit that referenced this pull request Feb 26, 2021
@ascorbic @vladar
fix(gatsby): Use vendored @reach/router (#29772)
47ad32f 
* fix(gatsby): Use vendored @reach/router

* Add typescript alias

* Add esm alias

* Fix tsconfig paths

* CHange imports inside gatsby

* Jest support

* Update peerdeps

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 8754e0c)
@gatsbybot gatsbybot mentioned this pull request Feb 26, 2021
Merged
vladar pushed a commit that referenced this pull request Feb 26, 2021
@ascorbic
fix(gatsby): Use vendored @reach/router (#29772) (#29811)
bd856ef 
* fix(gatsby): Use vendored @reach/router

* Add typescript alias

* Add esm alias

* Fix tsconfig paths

* CHange imports inside gatsby

* Jest support

* Update peerdeps

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 8754e0c)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@pieh pieh mentioned this pull request Mar 3, 2021
Closed
This was referenced Mar 17, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @wardpeet